Re: [PATCH] x86/vdso: ensure vdso32_enabled gets set to valid values only

From: Thomas Gleixner <tglx@linutronix.de>
To: Mathias Krause <minipli@googlemail.com>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
	Andy Lutomirski <luto@amacapital.net>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	Roland McGrath <roland@redhat.com>
Subject: Re: [PATCH] x86/vdso: ensure vdso32_enabled gets set to valid values only
Date: Mon, 10 Apr 2017 15:13:59 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.20.1704101500280.2906@nanos> (raw)
In-Reply-To: <1491424561-7187-1-git-send-email-minipli@googlemail.com>

On Wed, 5 Apr 2017, Mathias Krause wrote:
> @@ -62,13 +64,18 @@ int __init sysenter_setup(void)
>  /* Register vsyscall32 into the ABI table */
>  #include <linux/sysctl.h>
>  
> +static const int zero;
> +static const int one = 1;
> +
>  static struct ctl_table abi_table2[] = {
>  	{
>  		.procname	= "vsyscall32",
>  		.data		= &vdso32_enabled,
>  		.maxlen		= sizeof(int),
>  		.mode		= 0644,
> -		.proc_handler	= proc_dointvec
> +		.proc_handler	= proc_dointvec_minmax,
> +		.extra1		= (int *)&zero,
> +		.extra2		= (int *)&one,

This is still bustable. Let's start with: vdso32_enabled = false

    arch_setup_additional_pages()
	--> No mapping

					sysctl.vsysscall32()
					  --> vdso32_enabled = true

    create_elf_tables()
	if (vdso32_enabled) {
	   --> Add VDSO entry with NULL pointer

The vdso map code needs to store a flag in current which can be checked in
ARCH_DLINFO_IA32.

Thanks,

	tglx