From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752596AbdDKQ0D (ORCPT ); Tue, 11 Apr 2017 12:26:03 -0400 Received: from resqmta-ch2-03v.sys.comcast.net ([69.252.207.35]:59384 "EHLO resqmta-ch2-03v.sys.comcast.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750732AbdDKQ0B (ORCPT ); Tue, 11 Apr 2017 12:26:01 -0400 Date: Tue, 11 Apr 2017 11:26:00 -0500 (CDT) From: Christoph Lameter X-X-Sender: cl@east.gentwo.org To: Kees Cook cc: Michal Hocko , Andrew Morton , Pekka Enberg , David Rientjes , Joonsoo Kim , Linux-MM , LKML Subject: Re: [PATCH] mm: Add additional consistency check In-Reply-To: Message-ID: References: <20170404113022.GC15490@dhcp22.suse.cz> <20170404151600.GN15132@dhcp22.suse.cz> <20170404194220.GT15132@dhcp22.suse.cz> <20170404201334.GV15132@dhcp22.suse.cz> <20170411134618.GN6729@dhcp22.suse.cz> <20170411141956.GP6729@dhcp22.suse.cz> Content-Type: text/plain; charset=US-ASCII X-CMAE-Envelope: MS4wfBwNLh2snsd1KofPzFDnwkokDL0tf4fzYyp/nwEim79NvSUQRPGmb0cAHXC7lSHnlddMZAHOYGa69ISM0HLGJ9y6Z7XDhfMT7L50UjoU/D0pYtu7OXhG Cd8sI9zSVXK1HfrfTy+0V4MPAevu/EyNj34+4gGfJ7g2hGsLEM1dRjQwf8h58kB8yZtx2ZPeM7bOHY8nuwVbr4XRDSMjgLTLqUUFqWUofJCNItpwcrasnEFb mYsGD3zgSbGdY+bo8eKxJbVldE24Da13uuC1g08LYjA0BIS7ssoRlOwaCimoYlT8ZR/BixjF0IsCVFg+ftHCQ7nxGxqIdOtz5VlAy7m2WlYpLshSFg6NAfIS EoiA15CF9NK7dp7VSI/WNxEXsO6wbMM0Og46FXedkjiH8TdwRew= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 11 Apr 2017, Kees Cook wrote: > It seems that enabling the debug checks comes with a non-trivial > performance impact. I'd like to see consistency checks by default so > we can handle intentional heap corruption attacks better. This check > isn't expensive... Note also that these checks can be enabled and disabled at runtime for each slab cache. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-f199.google.com (mail-io0-f199.google.com [209.85.223.199]) by kanga.kvack.org (Postfix) with ESMTP id C5C126B03A4 for ; Tue, 11 Apr 2017 12:26:01 -0400 (EDT) Received: by mail-io0-f199.google.com with SMTP id o79so4331814ioo.15 for ; Tue, 11 Apr 2017 09:26:01 -0700 (PDT) Received: from resqmta-ch2-01v.sys.comcast.net (resqmta-ch2-01v.sys.comcast.net. [2001:558:fe21:29:69:252:207:33]) by mx.google.com with ESMTPS id p198si17962011ioe.85.2017.04.11.09.26.01 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 11 Apr 2017 09:26:01 -0700 (PDT) Date: Tue, 11 Apr 2017 11:26:00 -0500 (CDT) From: Christoph Lameter Subject: Re: [PATCH] mm: Add additional consistency check In-Reply-To: Message-ID: References: <20170404113022.GC15490@dhcp22.suse.cz> <20170404151600.GN15132@dhcp22.suse.cz> <20170404194220.GT15132@dhcp22.suse.cz> <20170404201334.GV15132@dhcp22.suse.cz> <20170411134618.GN6729@dhcp22.suse.cz> <20170411141956.GP6729@dhcp22.suse.cz> Content-Type: text/plain; charset=US-ASCII Sender: owner-linux-mm@kvack.org List-ID: To: Kees Cook Cc: Michal Hocko , Andrew Morton , Pekka Enberg , David Rientjes , Joonsoo Kim , Linux-MM , LKML On Tue, 11 Apr 2017, Kees Cook wrote: > It seems that enabling the debug checks comes with a non-trivial > performance impact. I'd like to see consistency checks by default so > we can handle intentional heap corruption attacks better. This check > isn't expensive... Note also that these checks can be enabled and disabled at runtime for each slab cache. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org