From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756349AbdDQPWf (ORCPT ); Mon, 17 Apr 2017 11:22:35 -0400 Received: from resqmta-ch2-06v.sys.comcast.net ([69.252.207.38]:55768 "EHLO resqmta-ch2-06v.sys.comcast.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754543AbdDQPWb (ORCPT ); Mon, 17 Apr 2017 11:22:31 -0400 Date: Mon, 17 Apr 2017 10:22:29 -0500 (CDT) From: Christoph Lameter X-X-Sender: cl@east.gentwo.org To: Michal Hocko cc: Kees Cook , Andrew Morton , Pekka Enberg , David Rientjes , Joonsoo Kim , Linux-MM , LKML Subject: Re: [PATCH] mm: Add additional consistency check In-Reply-To: <20170411193948.GA29154@dhcp22.suse.cz> Message-ID: References: <20170411134618.GN6729@dhcp22.suse.cz> <20170411141956.GP6729@dhcp22.suse.cz> <20170411164134.GA21171@dhcp22.suse.cz> <20170411183035.GD21171@dhcp22.suse.cz> <20170411185555.GE21171@dhcp22.suse.cz> <20170411193948.GA29154@dhcp22.suse.cz> Content-Type: text/plain; charset=US-ASCII X-CMAE-Envelope: MS4wfAidix5ZJN7Qq9yTtW/fVgDaGwbYKPNf+NnfpyEQtXrrHS7Bl6W0RiDVOqcN3LX3xY9HfTJ9pl3/ehcsVuCWqhIZx7uzNbnISQcB1Pp3svxJuc9EgT75 +RyIziMNYQ4SK4tQUU2XxN7Y0Y47aG+H0Uu+HRTZ42qRkYA/cy03E2Syhpho0eqHHCxlMAFsWJ7HR2aQLTn5byfycIT89re7WQevpMRcsibKsbEkWdeycojh yilWPIylUEK1BFv5EeJ7j6bP3E3osVkvnYRMF3BrcoAZ+Sq2kuCGnFitUYTan4nErWCmeVJDV+e7W9LNatxM5Z78MoZ2hE/az4U3QYdVlwtVRtPzzaaqpuRQ iCag0IUkfkbppwdCUZG0Ko/mOdwGIrFhTIm5fOvF8fP+cbyq8EA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 11 Apr 2017, Michal Hocko wrote: > On Tue 11-04-17 13:59:44, Cristopher Lameter wrote: > > On Tue, 11 Apr 2017, Michal Hocko wrote: > > > > > I didn't say anything like that. Hence the proposed patch which still > > > needs some more thinking and evaluation. > > > > This patch does not even affect kfree(). > > Ehm? Are we even talking about the same thing? The whole discussion was > to catch invalid pointers to _kfree_ and why BUG* is not the best way to > handle that. The patch does not do that. See my review. Invalid points to kfree are already caught with a bug on. See kfree in mm/slub.c From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-f199.google.com (mail-io0-f199.google.com [209.85.223.199]) by kanga.kvack.org (Postfix) with ESMTP id 6527C6B039F for ; Mon, 17 Apr 2017 11:22:32 -0400 (EDT) Received: by mail-io0-f199.google.com with SMTP id f66so113615614ioe.12 for ; Mon, 17 Apr 2017 08:22:32 -0700 (PDT) Received: from resqmta-ch2-04v.sys.comcast.net (resqmta-ch2-04v.sys.comcast.net. [2001:558:fe21:29:69:252:207:36]) by mx.google.com with ESMTPS id 37si12137339iod.71.2017.04.17.08.22.31 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 17 Apr 2017 08:22:31 -0700 (PDT) Date: Mon, 17 Apr 2017 10:22:29 -0500 (CDT) From: Christoph Lameter Subject: Re: [PATCH] mm: Add additional consistency check In-Reply-To: <20170411193948.GA29154@dhcp22.suse.cz> Message-ID: References: <20170411134618.GN6729@dhcp22.suse.cz> <20170411141956.GP6729@dhcp22.suse.cz> <20170411164134.GA21171@dhcp22.suse.cz> <20170411183035.GD21171@dhcp22.suse.cz> <20170411185555.GE21171@dhcp22.suse.cz> <20170411193948.GA29154@dhcp22.suse.cz> Content-Type: text/plain; charset=US-ASCII Sender: owner-linux-mm@kvack.org List-ID: To: Michal Hocko Cc: Kees Cook , Andrew Morton , Pekka Enberg , David Rientjes , Joonsoo Kim , Linux-MM , LKML On Tue, 11 Apr 2017, Michal Hocko wrote: > On Tue 11-04-17 13:59:44, Cristopher Lameter wrote: > > On Tue, 11 Apr 2017, Michal Hocko wrote: > > > > > I didn't say anything like that. Hence the proposed patch which still > > > needs some more thinking and evaluation. > > > > This patch does not even affect kfree(). > > Ehm? Are we even talking about the same thing? The whole discussion was > to catch invalid pointers to _kfree_ and why BUG* is not the best way to > handle that. The patch does not do that. See my review. Invalid points to kfree are already caught with a bug on. See kfree in mm/slub.c -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org