From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753336AbdEPWqm (ORCPT <rfc822;w@1wt.eu>);
        Tue, 16 May 2017 18:46:42 -0400
Received: from Galois.linutronix.de ([146.0.238.70]:41882 "EHLO
        Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751342AbdEPWql (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 16 May 2017 18:46:41 -0400
Date: Wed, 17 May 2017 00:46:37 +0200 (CEST)
From: Thomas Gleixner <tglx@linutronix.de>
To: Steven Rostedt <rostedt@goodmis.org>
cc: LKML <linux-kernel@vger.kernel.org>,
        Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [patch V2 17/17] sched: Enable might_sleep() and smp_processor_id()
 checks early
In-Reply-To: <20170516151236.3ca5d9ae@gandalf.local.home>
Message-ID: <alpine.DEB.2.20.1705170040440.2095@nanos>
References: <20170516184231.564888231@linutronix.de> <20170516184736.272225698@linutronix.de> <20170516151236.3ca5d9ae@gandalf.local.home>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 16 May 2017, Steven Rostedt wrote:
> On Tue, 16 May 2017 20:42:48 +0200
> Thomas Gleixner <tglx@linutronix.de> wrote:
> > +
> > +	/*
> > +	 * Enable might_sleep() and smp_processor_id() checks.
> > +	 * They cannot be enabled earlier because with CONFIG_PRREMPT=y
> 
> My cat's version of CONFIG_PREEMPT, it's CONFIG_ PRR EMPT!

I don't have a cat and I don't need one for creating typos. I'm perfectly
able to do that myself :)

> > +	 * kernel_thread() would trigger might_sleep() splats. With
> > +	 * CONFIG_PREEMPT_VOLUNTARY=y the init task might have scheduled
> > +	 * already, but it's stuck on the kthreadd_done completion.
> > +	 */
> > +	system_state = SYSTEM_SCHEDULING;
> > +
> >  	complete(&kthreadd_done);
> >  
> >  	/*
> > --- a/kernel/sched/core.c
> > +++ b/kernel/sched/core.c
> > @@ -6226,8 +6226,10 @@ void ___might_sleep(const char *file, in
> >  
> >  	if ((preempt_count_equals(preempt_offset) && !irqs_disabled() &&
> >  	     !is_idle_task(current)) ||
> > -	    system_state != SYSTEM_RUNNING || oops_in_progress)
> > +	    system_state == SYSTEM_BOOTING || system_state > SYSTEM_RUNNING ||
> > +	    oops_in_progress)
> >  		return;
> > +
> >  	if (time_before(jiffies, prev_jiffy + HZ) && prev_jiffy)
> >  		return;
> >  	prev_jiffy = jiffies;
> > --- a/lib/smp_processor_id.c
> > +++ b/lib/smp_processor_id.c
> > @@ -28,7 +28,7 @@ notrace static unsigned int check_preemp
> >  	/*
> >  	 * It is valid to assume CPU-locality during early bootup:
> >  	 */
> > -	if (system_state != SYSTEM_RUNNING)
> > +	if (system_state < SYSTEM_SCHEDULING)
> 
> Do we want to ignore halting or rebooting too?

I don't think so. After setting those states, interesting stuff like
device_shutdown() gets invoked. We want the coverage there.

Thanks,

	tglx