From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756947AbdEUUBN (ORCPT ); Sun, 21 May 2017 16:01:13 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:34777 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756846AbdEUUBM (ORCPT ); Sun, 21 May 2017 16:01:12 -0400 Date: Sun, 21 May 2017 22:01:07 +0200 (CEST) From: Thomas Gleixner To: Christoph Hellwig cc: LKML , linux-mm@kvack.org, Johannes Weiner , Michal Hocko , Christoph Lameter , Andrew Morton , Steven Rostedt , Peter Zijlstra Subject: Re: [PATCH] slub/memcg: Cure the brainless abuse of sysfs attributes In-Reply-To: <20170520131645.GA5058@infradead.org> Message-ID: References: <20170520131645.GA5058@infradead.org> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 20 May 2017, Christoph Hellwig wrote: > On Sat, May 20, 2017 at 12:52:03PM +0200, Thomas Gleixner wrote: > > This should be rewritten proper by adding a propagate() callback to those > > slub_attributes which must be propagated and avoid that insane conversion > > to and from ASCII > > Exactly.. > > >, but that's too large for a hot fix. > > What made this such a hot fix? Looks like this crap has been in > for quite a while. Well, having something in tree which uses stale or uninitialized buffers does justify a hot fix which can be easily backported to stable. Thanks, tglx From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f72.google.com (mail-wm0-f72.google.com [74.125.82.72]) by kanga.kvack.org (Postfix) with ESMTP id 2E0B3280850 for ; Sun, 21 May 2017 16:01:12 -0400 (EDT) Received: by mail-wm0-f72.google.com with SMTP id 139so21324860wmf.5 for ; Sun, 21 May 2017 13:01:12 -0700 (PDT) Received: from Galois.linutronix.de (Galois.linutronix.de. [2a01:7a0:2:106d:700::1]) by mx.google.com with ESMTPS id l193si7230934wmg.30.2017.05.21.13.01.10 for (version=TLS1_2 cipher=AES128-SHA bits=128/128); Sun, 21 May 2017 13:01:10 -0700 (PDT) Date: Sun, 21 May 2017 22:01:07 +0200 (CEST) From: Thomas Gleixner Subject: Re: [PATCH] slub/memcg: Cure the brainless abuse of sysfs attributes In-Reply-To: <20170520131645.GA5058@infradead.org> Message-ID: References: <20170520131645.GA5058@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: owner-linux-mm@kvack.org List-ID: To: Christoph Hellwig Cc: LKML , linux-mm@kvack.org, Johannes Weiner , Michal Hocko , Christoph Lameter , Andrew Morton , Steven Rostedt , Peter Zijlstra On Sat, 20 May 2017, Christoph Hellwig wrote: > On Sat, May 20, 2017 at 12:52:03PM +0200, Thomas Gleixner wrote: > > This should be rewritten proper by adding a propagate() callback to those > > slub_attributes which must be propagated and avoid that insane conversion > > to and from ASCII > > Exactly.. > > >, but that's too large for a hot fix. > > What made this such a hot fix? Looks like this crap has been in > for quite a while. Well, having something in tree which uses stale or uninitialized buffers does justify a hot fix which can be easily backported to stable. Thanks, tglx -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org