All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christopher Lameter <cl@linux.com>
To: "Huang, Ying" <ying.huang@intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
	linux-kernel@vger.kernel.org, Tejun Heo <tj@kernel.org>,
	Joerg Roedel <joro@8bytes.org>, Ingo Molnar <mingo@kernel.org>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Borislav Petkov <bp@suse.de>,
	Thomas Gleixner <tglx@linutronix.de>,
	Juergen Gross <jgross@suse.com>, Aaron Lu <aaron.lu@intel.com>
Subject: Re: [PATCH 0/3] IPI: Avoid to use 2 cache lines for one call_single_data
Date: Wed, 2 Aug 2017 08:54:40 -0500 (CDT)	[thread overview]
Message-ID: <alpine.DEB.2.20.1708020851150.23779@nuc-kabylake> (raw)
In-Reply-To: <20170802085220.4315-1-ying.huang@intel.com>

On Wed, 2 Aug 2017, Huang, Ying wrote:

> To allocate cache line size aligned percpu memory dynamically,
> alloc_percpu_aligned() is introduced and used in iova drivers too.

alloc_percpu() already aligns objects as specified when they are declared.

Moreover the function is improperly named since it aligns
to a cacheline(). If you want this then you would use

alloc_percpu_cacheline_aligned()

But then the alignment can already be requested by adding
__cacheline_aligned to the per cpu definition.

      parent reply	other threads:[~2017-08-02 13:54 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-02  8:52 [PATCH 0/3] IPI: Avoid to use 2 cache lines for one call_single_data Huang, Ying
2017-08-02  8:52 ` [PATCH 1/3] percpu: Add alloc_percpu_aligned() Huang, Ying
2017-08-02 13:50   ` Christopher Lameter
2017-08-03  0:33     ` Huang, Ying
2017-08-02  8:52 ` [PATCH 2/3] iova: Use alloc_percpu_aligned() Huang, Ying
2017-08-02  8:52 ` [PATCH 3/3] IPI: Avoid to use 2 cache lines for one call_single_data Huang, Ying
2017-08-02 10:18   ` Eric Dumazet
2017-08-02 10:53     ` Peter Zijlstra
2017-08-03  8:35     ` Huang, Ying
2017-08-03  8:57       ` Peter Zijlstra
2017-08-04  1:28         ` Huang, Ying
2017-08-04  2:05           ` Huang, Ying
2017-08-04  9:27             ` Peter Zijlstra
2017-08-05  0:47               ` Huang, Ying
2017-08-07  8:28                 ` Peter Zijlstra
2017-08-08  4:30                   ` Huang, Ying
2017-08-14  5:44                     ` Huang, Ying
2017-08-28  5:19                       ` Huang, Ying
2017-08-28  8:49                         ` Peter Zijlstra
2017-08-29 14:23                     ` [tip:locking/core] smp: Avoid using two cache lines for struct call_single_data tip-bot for Ying Huang
2017-08-04  9:20           ` [PATCH 3/3] IPI: Avoid to use 2 cache lines for one call_single_data Peter Zijlstra
2017-08-02 13:54 ` Christopher Lameter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.1708020851150.23779@nuc-kabylake \
    --to=cl@linux.com \
    --cc=aaron.lu@intel.com \
    --cc=bp@suse.de \
    --cc=jgross@suse.com \
    --cc=joro@8bytes.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=mpe@ellerman.id.au \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=tj@kernel.org \
    --cc=ying.huang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.