[Cocci] Comparing statement lists with SmPL

[julia.lawall@lip6.fr (Julia Lawall)]

On Wed, 16 Aug 2017, SF Markus Elfring wrote:

> > Unfortunately, the software version ?1.0.6-00186-g0acd38ee? does not like this
> > SmPL specification.
>
> I overlooked to add parentheses in my evolving SmPL script.
>
> @duplicated_code@
> identifier work;
> statement s1, s2;
> statement list sl;
> type T;
> @@
>  T work(...)
>  {
>  ... when any
> (
> *if ((...) < 0) {
> *   s1
> *   s2
>     ...
> *}
> &{
>     sl
>  }
> )
>  ...
> (
> *if ((...) < 0) {
> *   s1
> *   s2
>     ...
> *}
> &{
>     sl
>  }
> )
>  ...
>  }
>
>
> The following command does not show the expected source code analysis results at the moment.
>
> elfring at Sonne:~/Projekte/Coccinelle/janitor> spatch.opt show_same_statements2.cocci ../Probe/hdsp-excerpt1.c

There is no way that I can understand the problme without having the .c
file.

Note that most of your ...s have no annotation.  So they cannot contain
what comes before or after.  I would suggest to put when any on all of the
...s here that are at statement level.

julia

>
>
> Is there any more clarification needed for the use of SmPL conjunctions?
>
> Regards,
> Markus
>