All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Pasha Tatashin <pasha.tatashin@oracle.com>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org, mingo@redhat.com,
	peterz@infradead.org, hpa@zytor.com, douly.fnst@cn.fujitsu.com
Subject: Re: [PATCH v5 1/2] sched/clock: interface to allow timestamps early in boot
Date: Mon, 28 Aug 2017 17:15:29 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.20.1708281714080.1867@nanos> (raw)
In-Reply-To: <2d5087a2-2aca-aaba-4608-112facbd3208@oracle.com>

On Mon, 28 Aug 2017, Pasha Tatashin wrote:
> > > +/*
> > > + * Called once during to boot to initialize boot time.
> > > + */
> > > +void read_boot_clock64(struct timespec64 *ts)
> > 
> > And because its called only once, it does not need to be marked __init()
> > and must be kept around forever, right?
> 
> This is because every other architecture implements read_boot_clock64()
> without __init: arm, s390. Beside, the original weak stub does not have __init
> macro. So, I can certainly try to add it for x86, but I am not sure what is
> the behavior once __init section is gone, but weak implementation stays.

And what about fixing that everywhere?

Just because something is wrong, it does not mean that it needs to be
proliferated.

Thanks,

	tglx

  parent reply	other threads:[~2017-08-28 15:15 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-23 20:41 [PATCH v5 0/2] Early boot time stamps for x86 Pavel Tatashin
2017-08-23 20:41 ` [PATCH v5 1/2] sched/clock: interface to allow timestamps early in boot Pavel Tatashin
2017-08-25 22:54   ` Thomas Gleixner
2017-08-28 14:17     ` Pasha Tatashin
2017-08-28 15:13       ` Thomas Gleixner
2017-08-28 17:59         ` Pasha Tatashin
2017-08-28 15:15       ` Thomas Gleixner [this message]
2017-08-28 17:47         ` Pasha Tatashin
2017-08-23 20:41 ` [PATCH v5 2/2] x86/tsc: use tsc early Pavel Tatashin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.1708281714080.1867@nanos \
    --to=tglx@linutronix.de \
    --cc=douly.fnst@cn.fujitsu.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=pasha.tatashin@oracle.com \
    --cc=peterz@infradead.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.