From: Julia Lawall <julia.lawall@lip6.fr> To: Liam Breck <liam@networkimprov.net> Cc: "Sebastian Reichel" <sebastian.reichel@collabora.co.uk>, "Gilles Muller" <Gilles.Muller@lip6.fr>, "Nicolas Palix" <nicolas.palix@imag.fr>, "Michal Marek" <mmarek@suse.com>, cocci@systeme.lip6.fr, "Andrew F. Davis" <afd@ti.com>, "Pali Rohár" <pali.rohar@gmail.com>, "Linux PM mailing list" <linux-pm@vger.kernel.org> Subject: Re: [PATCH v3 0/5] bq27xxx_battery data memory update Date: Wed, 20 Sep 2017 11:45:05 +0200 (CEST) [thread overview] Message-ID: <alpine.DEB.2.20.1709201142150.3290@hadrien> (raw) In-Reply-To: <CAKvHMgTUrdF_ZmJYOB3jn020BMv-70MLpUBosBLstDrBN_KY9w@mail.gmail.com> > > Also, Coccinelle is comparing the list, but I guess you would prefer that > > it compare the set, to check for the cases where the names are the same > > but appear in a different order. > > Yes, ideally it would sort arrays before doing compare. Is that doable? Yes. > > >> > >> > I've attached the script and some fake data that I made to test it. The > >> > fake data has some added cases where I have replaced 27 in the structure > >> > name by 07. For my test data I get: > >> > > >> > bq07421_regs and bq27421_regs have the same registers > >> > bq07000_regs and bq27000_regs have the same registers > >> > bq07421_dm_regs and bq27421_dm_regs have the same registers > >> > bq07421_props and bq27421_props have the same properties > >> > bq07000_props and bq27000_props have the same properties > > We can just write > "%s & %s are identical" OK. But just to check, there are three fields of interest: regs, dm_regs and props. If for two entries regs are the same but dm_regs and props are different, you still want a warning about regs, right? This is the behavior that seemed to be in the C code and is what I have implemented. Or do you want a warning only if all three are the same. julia
WARNING: multiple messages have this Message-ID (diff)
From: julia.lawall@lip6.fr (Julia Lawall) To: cocci@systeme.lip6.fr Subject: [Cocci] [PATCH v3 0/5] bq27xxx_battery data memory update Date: Wed, 20 Sep 2017 11:45:05 +0200 (CEST) [thread overview] Message-ID: <alpine.DEB.2.20.1709201142150.3290@hadrien> (raw) In-Reply-To: <CAKvHMgTUrdF_ZmJYOB3jn020BMv-70MLpUBosBLstDrBN_KY9w@mail.gmail.com> > > Also, Coccinelle is comparing the list, but I guess you would prefer that > > it compare the set, to check for the cases where the names are the same > > but appear in a different order. > > Yes, ideally it would sort arrays before doing compare. Is that doable? Yes. > > >> > >> > I've attached the script and some fake data that I made to test it. The > >> > fake data has some added cases where I have replaced 27 in the structure > >> > name by 07. For my test data I get: > >> > > >> > bq07421_regs and bq27421_regs have the same registers > >> > bq07000_regs and bq27000_regs have the same registers > >> > bq07421_dm_regs and bq27421_dm_regs have the same registers > >> > bq07421_props and bq27421_props have the same properties > >> > bq07000_props and bq27000_props have the same properties > > We can just write > "%s & %s are identical" OK. But just to check, there are three fields of interest: regs, dm_regs and props. If for two entries regs are the same but dm_regs and props are different, you still want a warning about regs, right? This is the behavior that seemed to be in the C code and is what I have implemented. Or do you want a warning only if all three are the same. julia
next prev parent reply other threads:[~2017-09-20 9:46 UTC|newest] Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-08-24 3:36 [PATCH v3 0/5] bq27xxx_battery data memory update Liam Breck 2017-08-24 3:36 ` [PATCH v3 1/5] power: supply: bq27xxx: Create single chip data table Liam Breck 2017-08-24 3:36 ` [PATCH v3 2/5] power: supply: bq27xxx: Add chip IDs for previously shadowed chips Liam Breck 2017-08-24 3:36 ` [PATCH v3 3/5] power: supply: bq27xxx: Enable data memory update for certain chips Liam Breck 2017-08-24 3:36 ` [PATCH v3 4/5] power: supply: bq27xxx: Flag identical chip data when in debug mode Liam Breck 2017-08-24 3:36 ` [PATCH v3 5/5] power: supply: bq27xxx: Remove duplicate chip data arrays Liam Breck 2017-08-29 10:54 ` [PATCH v3 0/5] bq27xxx_battery data memory update Sebastian Reichel 2017-08-29 15:31 ` Andrew F. Davis 2017-08-29 21:22 ` Sebastian Reichel 2017-08-29 23:07 ` Liam Breck 2017-08-30 0:29 ` Sebastian Reichel 2017-08-30 0:29 ` [Cocci] " Sebastian Reichel 2017-08-30 1:14 ` Liam Breck 2017-08-30 1:14 ` [Cocci] " Liam Breck 2017-08-30 6:01 ` Julia Lawall 2017-08-30 6:01 ` [Cocci] " Julia Lawall 2017-08-31 9:54 ` Julia Lawall 2017-08-31 9:54 ` [Cocci] " Julia Lawall 2017-08-31 11:01 ` Liam Breck 2017-08-31 11:01 ` [Cocci] " Liam Breck 2017-08-31 11:33 ` Julia Lawall 2017-08-31 11:33 ` [Cocci] " Julia Lawall 2017-08-31 11:43 ` Liam Breck 2017-08-31 11:43 ` [Cocci] " Liam Breck 2017-09-05 19:15 ` Liam Breck 2017-09-05 19:15 ` [Cocci] " Liam Breck 2017-09-05 20:14 ` Julia Lawall 2017-09-05 20:14 ` [Cocci] " Julia Lawall 2017-09-18 0:45 ` Liam Breck 2017-09-18 0:45 ` [Cocci] " Liam Breck 2017-09-18 5:33 ` Julia Lawall 2017-09-18 5:33 ` [Cocci] " Julia Lawall 2017-09-19 21:47 ` Liam Breck 2017-09-19 21:47 ` [Cocci] " Liam Breck 2017-09-19 22:00 ` Julia Lawall 2017-09-19 22:00 ` [Cocci] " Julia Lawall 2017-09-19 22:36 ` Liam Breck 2017-09-19 22:36 ` [Cocci] " Liam Breck 2017-09-20 9:14 ` Julia Lawall 2017-09-20 9:14 ` [Cocci] " Julia Lawall 2017-09-20 9:41 ` Liam Breck 2017-09-20 9:41 ` [Cocci] " Liam Breck 2017-09-20 9:45 ` Julia Lawall [this message] 2017-09-20 9:45 ` Julia Lawall 2017-09-20 9:57 ` Liam Breck 2017-09-20 9:57 ` [Cocci] " Liam Breck 2017-09-27 10:02 ` Julia Lawall 2017-09-27 10:02 ` [Cocci] " Julia Lawall 2017-09-27 12:02 ` Liam Breck 2017-09-27 12:02 ` [Cocci] " Liam Breck 2017-09-27 12:16 ` Julia Lawall 2017-09-27 12:16 ` [Cocci] " Julia Lawall 2017-09-27 12:46 ` Liam Breck 2017-09-27 12:46 ` [Cocci] " Liam Breck 2017-10-01 11:59 ` Julia Lawall 2017-10-01 11:59 ` [Cocci] " Julia Lawall 2017-09-27 13:12 ` Liam Breck 2017-09-27 13:12 ` [Cocci] " Liam Breck 2017-09-27 13:25 ` Julia Lawall 2017-09-27 13:25 ` [Cocci] " Julia Lawall 2017-09-27 13:25 ` Julia Lawall 2017-09-27 13:25 ` [Cocci] " Julia Lawall 2017-08-29 22:29 ` Liam Breck
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=alpine.DEB.2.20.1709201142150.3290@hadrien \ --to=julia.lawall@lip6.fr \ --cc=Gilles.Muller@lip6.fr \ --cc=afd@ti.com \ --cc=cocci@systeme.lip6.fr \ --cc=liam@networkimprov.net \ --cc=linux-pm@vger.kernel.org \ --cc=mmarek@suse.com \ --cc=nicolas.palix@imag.fr \ --cc=pali.rohar@gmail.com \ --cc=sebastian.reichel@collabora.co.uk \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.