From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julia Lawall Subject: Re: [PATCH v3 0/5] bq27xxx_battery data memory update Date: Wed, 20 Sep 2017 11:45:05 +0200 (CEST) Message-ID: References: <20170824033617.20840-1-liam@networkimprov.net> <20170830002939.ns43wldvffmwqhuv@earth> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Return-path: Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:25828 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751750AbdITJqC (ORCPT ); Wed, 20 Sep 2017 05:46:02 -0400 In-Reply-To: Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Liam Breck Cc: Sebastian Reichel , Gilles Muller , Nicolas Palix , Michal Marek , cocci@systeme.lip6.fr, "Andrew F. Davis" , =?ISO-8859-15?Q?Pali_Roh=E1r?= , Linux PM mailing list > > Also, Coccinelle is comparing the list, but I guess you would prefer that > > it compare the set, to check for the cases where the names are the same > > but appear in a different order. > > Yes, ideally it would sort arrays before doing compare. Is that doable? Yes. > > >> > >> > I've attached the script and some fake data that I made to test it. The > >> > fake data has some added cases where I have replaced 27 in the structure > >> > name by 07. For my test data I get: > >> > > >> > bq07421_regs and bq27421_regs have the same registers > >> > bq07000_regs and bq27000_regs have the same registers > >> > bq07421_dm_regs and bq27421_dm_regs have the same registers > >> > bq07421_props and bq27421_props have the same properties > >> > bq07000_props and bq27000_props have the same properties > > We can just write > "%s & %s are identical" OK. But just to check, there are three fields of interest: regs, dm_regs and props. If for two entries regs are the same but dm_regs and props are different, you still want a warning about regs, right? This is the behavior that seemed to be in the C code and is what I have implemented. Or do you want a warning only if all three are the same. julia From mboxrd@z Thu Jan 1 00:00:00 1970 From: julia.lawall@lip6.fr (Julia Lawall) Date: Wed, 20 Sep 2017 11:45:05 +0200 (CEST) Subject: [Cocci] [PATCH v3 0/5] bq27xxx_battery data memory update In-Reply-To: References: <20170824033617.20840-1-liam@networkimprov.net> <20170830002939.ns43wldvffmwqhuv@earth> Message-ID: To: cocci@systeme.lip6.fr List-Id: cocci@systeme.lip6.fr > > Also, Coccinelle is comparing the list, but I guess you would prefer that > > it compare the set, to check for the cases where the names are the same > > but appear in a different order. > > Yes, ideally it would sort arrays before doing compare. Is that doable? Yes. > > >> > >> > I've attached the script and some fake data that I made to test it. The > >> > fake data has some added cases where I have replaced 27 in the structure > >> > name by 07. For my test data I get: > >> > > >> > bq07421_regs and bq27421_regs have the same registers > >> > bq07000_regs and bq27000_regs have the same registers > >> > bq07421_dm_regs and bq27421_dm_regs have the same registers > >> > bq07421_props and bq27421_props have the same properties > >> > bq07000_props and bq27000_props have the same properties > > We can just write > "%s & %s are identical" OK. But just to check, there are three fields of interest: regs, dm_regs and props. If for two entries regs are the same but dm_regs and props are different, you still want a warning about regs, right? This is the behavior that seemed to be in the C code and is what I have implemented. Or do you want a warning only if all three are the same. julia