Re: [Outreachy kernel] [PATCH] staging: wilc1000: Blank lines aren't necessary before a close brace '}'

From: Julia Lawall <julia.lawall@lip6.fr>
To: Keerthi Reddy <keerthigd4990@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH] staging: wilc1000: Blank lines aren't necessary before a close brace '}'
Date: Sat, 23 Sep 2017 20:10:38 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.20.1709232009130.5987@hadrien> (raw)
In-Reply-To: <20170923174900.GA9303@manoharreddy>

On Sat, 23 Sep 2017, Keerthi Reddy wrote:

>  Sat, Sep 23, 2017 at 07:28:36PM +0200, Julia Lawall wrote:
>
> > This is on the same file as your previous patch, so they have to be put in
> > a series.
> Can I update the patch previous patch into a patch set by combining this
> one the previous one?

I'm not sure to completely understand the question.  Each patch should do
only one thing.  These are doing two different things, so they should not
be in the same patch.  You need to make a series, with one being 1/2 and
the next being 2/2.  How to do this is described in the tutorial.

julia

> >
> > On Sat, 23 Sep 2017, Keerthi Reddy wrote:
> >
> > > Before closing the brace, the blank line is not needed. That blank
> > > line has not meaning here. so remove it.
> >
> > This is on the same file as your previous patch, so they have to be put in
> > a series.
> >
> > julia
> >
> > >
> > > Signed-off-by: Keerthi Reddy <keerthigd4990@gmail.com>
> > > ---
> > >  drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 1 -
> > >  1 file changed, 1 deletion(-)
> > >
> > > diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
> > > index 36dc2a0..e7882b2 100644
> > > --- a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
> > > +++ b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
> > > @@ -1111,7 +1111,6 @@ static int del_key(struct wiphy *wiphy, struct net_device *netdev,
> > >  		g_key_gtk_params.key = NULL;
> > >  		kfree(g_key_gtk_params.seq);
> > >  		g_key_gtk_params.seq = NULL;
> > > -
> > >  	}
> > >
> > >  	if (key_index >= 0 && key_index <= 3) {
> > > --
> > > 2.7.4
> > >
> > > --
> > > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> > > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > > To post to this group, send email to outreachy-kernel@googlegroups.com.
> > > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170923172108.GA8880%40manoharreddy.
> > > For more options, visit https://groups.google.com/d/optout.
> > >
>