All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julia Lawall <julia.lawall@lip6.fr>
To: Keerthi Reddy <keerthigd4990@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH 1/2] staging: wilc1000: No space is necessary after a cast
Date: Sat, 23 Sep 2017 22:03:49 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.20.1709232203370.5987@hadrien> (raw)
In-Reply-To: <0a42225d2ac8416a7b74f2c9cea55bfd4d0521e8.1506192874.git.keerthigd4990@gmail.com>



On Sun, 24 Sep 2017, Keerthi Reddy wrote:

> A space after type casting is not needed. All the other typecasts
> in this file don't put space after typecast. so remove space
> after typecast at this line.
>
> checked with checkpatch.pl script
>
> Signed-off-by: Keerthi Reddy <keerthigd4990@gmail.com>

Acked-by: Julia Lawall <julia.lawall@lip6.fr>

> ---
>  drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
> index ac5aaaf..36dc2a0 100644
> --- a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
> +++ b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
> @@ -1617,7 +1617,7 @@ static int mgmt_tx(struct wiphy *wiphy,
>
>  	*cookie = (unsigned long)buf;
>  	priv->u64tx_cookie = *cookie;
> -	mgmt = (const struct ieee80211_mgmt *) buf;
> +	mgmt = (const struct ieee80211_mgmt *)buf;
>
>  	if (ieee80211_is_mgmt(mgmt->frame_control)) {
>  		mgmt_tx = kmalloc(sizeof(struct p2p_mgmt_data), GFP_KERNEL);
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/0a42225d2ac8416a7b74f2c9cea55bfd4d0521e8.1506192874.git.keerthigd4990%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>


  reply	other threads:[~2017-09-23 20:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-23 18:57 [PATCH 0/2] staging: wilc1000: follow coding guidelines Keerthi Reddy
2017-09-23 18:57 ` [PATCH 1/2] staging: wilc1000: No space is necessary after a cast Keerthi Reddy
2017-09-23 20:03   ` Julia Lawall [this message]
2017-09-23 18:58 ` [PATCH 2/2] staging: wilc1000: Blank lines aren't necessary before a close brace '}' Keerthi Reddy
2017-09-23 20:04   ` [Outreachy kernel] " Julia Lawall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.1709232203370.5987@hadrien \
    --to=julia.lawall@lip6.fr \
    --cc=keerthigd4990@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.