All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julia Lawall <julia.lawall@lip6.fr>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Srishti Sharma <srishtishar@gmail.com>,
	gregkh@linuxfoundation.org,  devel@driverdev.osuosl.org,
	outreachy-kernel@googlegroups.com,  linux-kernel@vger.kernel.org
Subject: Re: [Outreachy kernel] Re: [PATCH] Staging: rtl8188eu: core: Use list_for_each_entry_safe
Date: Wed, 4 Oct 2017 15:39:30 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.20.1710041537060.2815@hadrien> (raw)
In-Reply-To: <20171004112103.cvu5ipkudfpz2adc@mwanda>



On Wed, 4 Oct 2017, Dan Carpenter wrote:

> On Wed, Oct 04, 2017 at 01:58:32AM +0530, Srishti Sharma wrote:
> > Use list_for_each_entry_safe when the list elements may get deleted
> > during traversal.
>
> This patch is fine as a cleanup but none of these are actually buggy.

I'm not sure what you are getting at with the comment.  The commit doesn't
say that they were buggy.  Perhaps the commit message could have been more
verbose, like "Use list operators on list_head values.
List_for_each_entry_safe is needed because the list elements get deleted
during the traversal"?

thanks,
julia

>
> regards,
> dan carpenter
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20171004112103.cvu5ipkudfpz2adc%40mwanda.
> For more options, visit https://groups.google.com/d/optout.
>


  reply	other threads:[~2017-10-04 13:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-03 20:28 [PATCH] Staging: rtl8188eu: core: Use list_for_each_entry_safe Srishti Sharma
2017-10-04 11:21 ` Dan Carpenter
2017-10-04 13:39   ` Julia Lawall [this message]
2017-10-04 14:40     ` [Outreachy kernel] " Dan Carpenter
2017-10-04 14:41       ` Julia Lawall
2017-10-04 15:05         ` Srishti Sharma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.1710041537060.2815@hadrien \
    --to=julia.lawall@lip6.fr \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=outreachy-kernel@googlegroups.com \
    --cc=srishtishar@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.