From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752130AbdJSIuu (ORCPT ); Thu, 19 Oct 2017 04:50:50 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:60224 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751908AbdJSIur (ORCPT ); Thu, 19 Oct 2017 04:50:47 -0400 Date: Thu, 19 Oct 2017 10:50:44 +0200 (CEST) From: Thomas Gleixner To: Greg Kroah-Hartman cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Kate Stewart , Philippe Ombredanne Subject: Re: [PATCH] USB: add SPDX identifiers to all files in drivers/usb/ In-Reply-To: <20171019083832.GA21820@kroah.com> Message-ID: References: <20171019083832.GA21820@kroah.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="8323329-756619082-1508403045=:1971" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-756619082-1508403045=:1971 Content-Type: text/plain; charset=US-ASCII On Thu, 19 Oct 2017, Greg Kroah-Hartman wrote: > It's good to have SPDX identifiers in all files to make it easier to > audit the kernel tree for correct licenses. This patch adds these > identifiers to all files in drivers/usb/ based on a script and data from > Thomas Gleixner, Philippe Ombredanne, and Kate Stewart. > > Cc: Thomas Gleixner > Cc: Kate Stewart > Cc: Philippe Ombredanne > Signed-off-by: Greg Kroah-Hartman > --- > Unless someone really complains, I'm going to add this to my tree for > 4.15-rc1. > > > diff --git a/drivers/usb/Makefile b/drivers/usb/Makefile > index 9650b351c26c..cb8d902b801d 100644 > --- a/drivers/usb/Makefile > +++ b/drivers/usb/Makefile > @@ -1,6 +1,7 @@ > # > # Makefile for the kernel USB device drivers. > # > +# SPDX-License-Identifier: GPL-2.0 The last discussion about this was to add the identifier as the first line of the file or as the second in case of files with a shebang in the first one. I think you missed the last version of the script. Attached. Thanks, tglx --8323329-756619082-1508403045=:1971 Content-Type: text/x-python; name=spdxtags2.py Content-Transfer-Encoding: BASE64 Content-ID: Content-Description: Content-Disposition: attachment; filename=spdxtags2.py IyEvdXNyL2Jpbi9lbnYgcHl0aG9uDQojDQppbXBvcnQgc3lzDQppbXBvcnQg b3MNCg0KZGVmIGluc2VydF9hdChzcmNsaW5lcywgcG9zLCB0YWcsIHN0eWxl KToNCiAgICBzcmNsaW5lcy5pbnNlcnQocG9zLCAnJXMgU1BEWC1MaWNlbnNl LUlkZW50aWZpZXI6ICVzXG4nICUoc3R5bGUsIHRhZykpDQogICAgcmV0dXJu IFRydWUNCg0KZGVmIGhhbmRsZV9jX2goc3JjbGluZXMsIHRhZyk6DQogICAg cmV0dXJuIGluc2VydF9hdChzcmNsaW5lcywgMCwgdGFnLCAnLy8nKQ0KDQpk ZWYgaGFuZGxlX2FzbShzcmNsaW5lcywgdGFnKToNCiAgICAjIFN0dXBpZCBz ZWFyY2ggZm9yIGEgcHJvcGVyIHN0eWxlIHRvIGNvbW1lbnQgdGhlIFNQRFgg dGFnDQogICAgcG9zID0gMA0KICAgIHN0eWxlID0gTm9uZQ0KICAgIGZvciBs aW5lIGluIHNyY2xpbmVzOg0KICAgICAgICBwb3MgKz0gMQ0KICAgICAgICBp ZiBsaW5lLnN0YXJ0c3dpdGgoJzs7OycpOg0KICAgICAgICAgICAgc3R5bGUg PSAnOzs7Jw0KICAgICAgICBlbGlmIGxpbmUuc3RhcnRzd2l0aCgnOzsnKToN CiAgICAgICAgICAgIHN0eWxlID0gJzs7Jw0KICAgICAgICBlbGlmIGxpbmUu c3RhcnRzd2l0aCgnOycpOg0KICAgICAgICAgICAgc3R5bGUgPSAnOycNCiAg ICAgICAgZWxpZiBsaW5lLnN0YXJ0c3dpdGgoJ3wnKToNCiAgICAgICAgICAg IHN0eWxlID0gJ3wnDQogICAgICAgIGVsaWYgbGluZS5zdGFydHN3aXRoKCch Jyk6DQogICAgICAgICAgICBzdHlsZSA9ICchJw0KICAgICAgICBlbGlmIGxp bmUuc3RhcnRzd2l0aCgnLy8nKToNCiAgICAgICAgICAgIHN0eWxlID0gJy8v Jw0KICAgICAgICBlbGlmIGxpbmUuc3RhcnRzd2l0aCgiLyoiKToNCiAgICAg ICAgICAgIHN0eWxlID0gJy8vJw0KICAgICAgICBlbHNlOg0KICAgICAgICAg ICAgY29udGludWUNCiAgICAgICAgcmV0dXJuIGluc2VydF9hdChzcmNsaW5l cywgMCwgdGFnLCBzdHlsZSkNCiAgICByZXR1cm4gRmFsc2UNCg0KZGVmIGhh bmRsZV9zaChzcmNsaW5lcywgdGFnKToNCiAgICByZXR1cm4gaW5zZXJ0X2F0 KHNyY2xpbmVzLCAxLCB0YWcsICcjJykNCg0KdGYgPSBvcGVuKHN5cy5hcmd2 WzFdKQ0KDQpmb3IgZW50cnkgaW4gdGYucmVhZGxpbmVzKCk6DQoNCiAgICBp ZiBsZW4oZW50cnkuc3RyaXAoKSkgPT0gMDoNCiAgICAgICAgY29udGludWUN Cg0KICAgIG5yLCBmbmFtZSwgdGFnID0gZW50cnkuc3RyaXAoKS5zcGxpdCgn LCcpDQogICAgIyBGSVhNRTogVXNlIGEgcHJvcGVyIGVuY29kZXINCiAgICBm bmFtZSA9IGZuYW1lLnJlcGxhY2UoJyUyQycsJywnKQ0KICAgIGlmIHRhZyA9 PSAnTk9UQUcnOg0KICAgICAgICBwcmludCgiU2tpcHBpbmcgJXMiICVmbmFt ZSkNCiAgICAgICAgY29udGludWUNCg0KICAgIGlmIG5vdCBvcy5wYXRoLmlz ZmlsZShmbmFtZSk6DQogICAgICAgIHByaW50KCJGQUlMOiBGaWxlICVzIGRv ZXMgbm90IGV4aXN0IGFueW1vcmUiICVmbmFtZSkNCiAgICAgICAgY29udGlu dWUNCiAgICANCiAgICBzcmNsaW5lcyA9IG9wZW4oZm5hbWUpLnJlYWRsaW5l cygpDQoNCiAgICBkb25lID0gRmFsc2UNCiAgICBmb3IgbGluZSBpbiBzcmNs aW5lczoNCiAgICAgICAgaWYgbGluZS5maW5kKCdTUERYLUxpY2Vuc2UtSWRl bnRpZmllcicpID49IDA6DQogICAgICAgICAgICBkb25lID0gVHJ1ZQ0KICAg ICAgICAgICAgYnJlYWsNCg0KICAgIGlmIGRvbmU6DQogICAgICAgIHByaW50 KCJTUERYIGlkIGV4aXN0cyBhbHJlYWR5IGluICVzIiAlZm5hbWUpDQogICAg ICAgIGNvbnRpbnVlDQoNCiAgICBvayA9IEZhbHNlDQogICAgaWYgZm5hbWUu ZW5kc3dpdGgoJy5jJykgb3IgZm5hbWUuZW5kc3dpdGgoJy5oJykgb3IgZm5h bWUuZW5kc3dpdGgoJy51YycpOg0KICAgICAgICBvayA9IGhhbmRsZV9jX2go c3JjbGluZXMsIHRhZykNCg0KICAgIGVsaWYgZm5hbWUuZW5kc3dpdGgoJy5T Jyk6DQogICAgICAgIG9rID0gaGFuZGxlX2FzbShzcmNsaW5lcywgdGFnKQ0K ICAgICAgICAgICAgDQogICAgZWxpZiBmbmFtZS5lbmRzd2l0aCgnLmNvY2Np Jyk6DQogICAgICAgIG9rID0gaW5zZXJ0X2F0KHNyY2xpbmVzLCAwLCB0YWcs ICcvLycpDQogICAgICAgIA0KICAgIGVsaWYgZm5hbWUuZW5kc3dpdGgoJy5k dHMnKSBvciBmbmFtZS5lbmRzd2l0aCgnLmR0c2knKToNCiAgICAgICAgb2sg PSBpbnNlcnRfYXQoc3JjbGluZXMsIDAsIHRhZywgJy8vJykNCg0KICAgIGVs aWYgZm5hbWUuZW5kc3dpdGgoJy5weScpIG9yIGZuYW1lLmVuZHN3aXRoKCcu dGMnKSBvciBmbmFtZS5lbmRzd2l0aCgnLnNoJyk6DQogICAgICAgIG9rID0g aW5zZXJ0X2F0KHNyY2xpbmVzLCAxLCB0YWcsICcjJykNCg0KICAgIGVsaWYg Zm5hbWUuZW5kc3dpdGgoJ01ha2VmaWxlJykgb3IgZm5hbWUuZmluZCgnS2Nv bmZpZycpID4gMCBvciBmbmFtZS5maW5kKCdLYnVpbGQnKSA+IDA6DQogICAg ICAgIG9rID0gaW5zZXJ0X2F0KHNyY2xpbmVzLCAwLCB0YWcsICcjJykNCg0K ICAgIGVsc2U6DQogICAgICAgIHByaW50KCJVbmhhbmRsZWQgb3IgaWdub3Jl ZCBmaWxlICVzIiAlZm5hbWUpDQogICAgICAgIGNvbnRpbnVlDQoNCiAgICBp ZiBvazoNCiAgICAgICAgb3BlbihmbmFtZSwgJ3cnKS53cml0ZWxpbmVzKHNy Y2xpbmVzKQ0KICAgICAgICBwcmludCgiSW5zZXJ0ZWQgJXMgaW50byAlcyIg JSh0YWcsIGZuYW1lKSkNCiAgICBlbHNlOg0KICAgICAgICBwcmludCgiRkFJ TDogTm8gcGxhY2UgZm9yIGluc2VydGlvbiBmb3VuZCAlcyIgJWZuYW1lKQ0K DQoNCg== --8323329-756619082-1508403045=:1971--