All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Ingo Molnar <mingo@kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Joerg Roedel <joro@8bytes.org>, "H. Peter Anvin" <hpa@zytor.com>,
	linux-tip-commits@vger.kernel.org
Subject: Re: [tip:x86/timers] x86: Don't include asm/x86_init.h in asm/setup.h
Date: Fri, 20 Oct 2017 13:48:27 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.20.1710201347140.2908@nanos> (raw)
In-Reply-To: <CAK8P3a1BVtTQGtj=CmQo4zn4qGAHqDED1eqkFOm-zgXj-kN97A@mail.gmail.com>

On Fri, 20 Oct 2017, Arnd Bergmann wrote:
> On Fri, Oct 20, 2017 at 1:11 PM, Ingo Molnar <mingo@kernel.org> wrote:
> >>  #include <asm/iommu_table.h>
> >> +#include <asm/x86_init.h>
> >>
> >>  #include "irq_remapping.h"
> >
> > This breaks the IA64 build:
> >
> >   drivers/iommu/dmar.c:44:26: fatal error: asm/x86_init.h: No such file or directory
> 
> I've sent a fixup to add an #ifdef around it now. Alternatively, we
> could include
> it implicitly in asm/iommu_table.h, which would avoid the #ifdef but
> seem a little
> hacky.

Hrm. Both solutions are ugly. Is there no other way to split stuff up in
those headers (maybe create an extra one).

Thanks,

	tglx

  reply	other threads:[~2017-10-20 11:48 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-19 10:53 [PATCH 1/2] x86: don't include asm/x86_init.h in asm/setup.h Arnd Bergmann
2017-10-19 10:57 ` [PATCH v2 2/2] x86: convert x86_platform_ops to timespec64 Arnd Bergmann
2017-10-19 10:57   ` Arnd Bergmann
2017-10-19 11:46   ` Paolo Bonzini
2017-10-19 11:46   ` Paolo Bonzini
2017-10-19 13:46   ` [tip:x86/timers] x86: Convert " tip-bot for Arnd Bergmann
2017-10-19 13:45 ` [tip:x86/timers] x86: Don't include asm/x86_init.h in asm/setup.h tip-bot for Arnd Bergmann
2017-10-20 11:11   ` Ingo Molnar
2017-10-20 11:37     ` Arnd Bergmann
2017-10-20 11:48       ` Thomas Gleixner [this message]
2017-10-20 12:09         ` Arnd Bergmann
2017-10-20 11:41     ` Thomas Gleixner
2017-10-20 12:20       ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.1710201347140.2908@nanos \
    --to=tglx@linutronix.de \
    --cc=arnd@arndb.de \
    --cc=hpa@zytor.com \
    --cc=joro@8bytes.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.