From: Thomas Gleixner <tglx@linutronix.de>
To: Joao Martins <joao.m.martins@oracle.com>
Cc: Juergen Gross <jgross@suse.com>,
xen-devel <xen-devel@lists.xenproject.org>,
kvm@vger.kernel.org, Radim Krcmar <rkrcmar@redhat.com>,
x86@kernel.org, linux-kernel@vger.kernel.org,
Andy Lutomirski <luto@amacapital.net>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>
Subject: Re: [PATCH v7 2/5] x86/pvclock: add setter for pvclock_pvti_cpu0_va
Date: Wed, 8 Nov 2017 12:06:40 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.20.1711081203590.1937__25817.5199073323$1510139284$gmane$org@nanos> (raw)
In-Reply-To: <d3957335-f093-9d64-7f82-f4dc97c38268@oracle.com>
On Tue, 7 Nov 2017, Joao Martins wrote:
> On 11/06/2017 04:09 PM, Paolo Bonzini wrote:
> > On 19/10/2017 15:39, Joao Martins wrote:
> >> Right now there is only a pvclock_pvti_cpu0_va() which is defined
> >> on kvmclock since:
> >>
> >> commit dac16fba6fc5
> >> ("x86/vdso: Get pvclock data from the vvar VMA instead of the fixmap")
> >>
> >> The only user of this interface so far is kvm. This commit adds a
> >> setter function for the pvti page and moves pvclock_pvti_cpu0_va
> >> to pvclock, which is a more generic place to have it; and would
> >> allow other PV clocksources to use it, such as Xen.
> >>
> >> Signed-off-by: Joao Martins <joao.m.martins@oracle.com>
> >> Acked-by: Andy Lutomirski <luto@kernel.org>
> >
> > Acked-by: Paolo Bonzini <pbonzini@redhat.com>
> >
> > IOW, the Xen folks are free to pick up the whole series. :)
> >
> Thank you!
>
> I guess only x86 maintainers Ack is left - any comments?
The only nit-pick I have are the convoluted function names:
pvclock_set_pvti_cpu0_va() pvclock_pvti_cpu0_va()
What on earth does that mean?
Aside of that can you please make it at least symetric, i.e. _set_ and
_get_ ?
Other than that:
Acked-by: Thomas Gleixner <tglx@linutronix.de>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-11-08 11:06 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-19 13:39 [PATCH v7 0/5] x86/xen: pvclock vdso support Joao Martins
2017-10-19 13:39 ` [PATCH v7 1/5] ptp_kvm: probe for kvm guest availability Joao Martins
2017-10-20 14:33 ` Radim Krcmar
2017-10-20 14:33 ` Radim Krcmar
2017-10-19 13:39 ` Joao Martins
2017-10-19 13:39 ` [PATCH v7 2/5] x86/pvclock: add setter for pvclock_pvti_cpu0_va Joao Martins
2017-10-19 13:39 ` Joao Martins
2017-11-06 16:09 ` Paolo Bonzini
2017-11-06 16:09 ` Paolo Bonzini
2017-11-07 19:29 ` Joao Martins
2017-11-08 11:06 ` Thomas Gleixner [this message]
2017-11-08 11:06 ` Thomas Gleixner
2017-11-08 13:01 ` Joao Martins
2017-11-08 13:10 ` Thomas Gleixner
2017-11-08 13:10 ` Thomas Gleixner
2017-11-08 13:01 ` Joao Martins
2017-11-07 19:29 ` Joao Martins
2017-10-19 13:39 ` [PATCH v7 3/5] x86/xen/time: set pvclock flags on xen_time_init() Joao Martins
2017-10-19 13:39 ` Joao Martins
2017-10-19 13:39 ` [PATCH v7 4/5] x86/xen/time: setup vcpu 0 time info page Joao Martins
2017-10-19 13:39 ` Joao Martins
2017-10-19 13:39 ` [PATCH v7 5/5] MAINTAINERS: xen, kvm: track pvclock-abi.h changes Joao Martins
2017-10-19 13:39 ` Joao Martins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='alpine.DEB.2.20.1711081203590.1937__25817.5199073323$1510139284$gmane$org@nanos' \
--to=tglx@linutronix.de \
--cc=boris.ostrovsky@oracle.com \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=joao.m.martins@oracle.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.