All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Sudeep Holla <sudeep.holla@arm.com>,
	Arnd Bergmann <arnd@arndb.de>,
	Benjamin Gaignard <benjamin.gaignard@linaro.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] clocksource/drivers/timer-of: mark timer_of_exit as __init
Date: Mon, 13 Nov 2017 16:10:06 +0100 (CET)	[thread overview]
Message-ID: <alpine.DEB.2.20.1711131606460.1851@nanos> (raw)
In-Reply-To: <6cdbbe9b-309a-7cb9-648f-7df2295c510f@linaro.org>

On Mon, 13 Nov 2017, Daniel Lezcano wrote:
> On 13/11/2017 11:11, Sudeep Holla wrote:
> > Agreed, may be if we add users which is called from init functions, the
> > warning should disappear. Also as tglx suggested, we could rename if it's
> > just used from init function error/exit paths.
> 
> The drivers are not compiled as module AFAICT, the function will be
> called in the init error path.

Ok, if the consensus is that this is used for common cleanup in __init
error handling, then please can someone submit a new version of this which
renames the function to something like timer_of_cleanup() and add the
__init annotation to it? And while at it please add a kernel doc comment to
that effect.

Thanks,

	tglx

  reply	other threads:[~2017-11-13 15:10 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-06 13:34 [PATCH] clocksource/drivers/timer-of: mark timer_of_exit as __init Arnd Bergmann
2017-11-12 21:16 ` Thomas Gleixner
2017-11-12 22:24   ` Arnd Bergmann
2017-11-12 22:27     ` Thomas Gleixner
2017-11-13  9:27       ` Benjamin Gaignard
2017-11-13 10:11     ` Sudeep Holla
2017-11-13 14:58       ` Daniel Lezcano
2017-11-13 15:10         ` Thomas Gleixner [this message]
2017-11-13 15:10         ` Sudeep Holla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.1711131606460.1851@nanos \
    --to=tglx@linutronix.de \
    --cc=arnd@arndb.de \
    --cc=benjamin.gaignard@linaro.org \
    --cc=daniel.lezcano@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sudeep.holla@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.