From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754991AbdKNPLo (ORCPT ); Tue, 14 Nov 2017 10:11:44 -0500 Received: from Galois.linutronix.de ([146.0.238.70]:37814 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753869AbdKNPLh (ORCPT ); Tue, 14 Nov 2017 10:11:37 -0500 Date: Tue, 14 Nov 2017 16:11:31 +0100 (CET) From: Thomas Gleixner To: Michal Hocko cc: Andrew Morton , Tejun Heo , Peter Zijlstra , Johannes Weiner , Mel Gorman , linux-mm@kvack.org, LKML Subject: Re: [PATCH] mm: drop hotplug lock from lru_add_drain_all In-Reply-To: Message-ID: References: <20171114135348.28704-1-mhocko@kernel.org> <20171114142347.syzyd6tlnpe2afur@dhcp22.suse.cz> <20171114143200.brmgskoqxjlrhrzx@dhcp22.suse.cz> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 14 Nov 2017, Thomas Gleixner wrote: > On Tue, 14 Nov 2017, Michal Hocko wrote: > > > On Tue 14-11-17 15:23:47, Michal Hocko wrote: > > [...] > > > +/* > > > + * Doesn't need any cpu hotplug locking because we do rely on per-cpu > > > + * kworkers being shut down before our page_alloc_cpu_dead callback is > > > + * executed on the offlined cpu > > > + */ > > > void lru_add_drain_all(void) > > > { > > > static DEFINE_MUTEX(lock); > > > > Ble the part of the comment didn't go through > > Looks good. With that added, feel free to add: Acked-by: Thomas Gleixner From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f197.google.com (mail-wr0-f197.google.com [209.85.128.197]) by kanga.kvack.org (Postfix) with ESMTP id 995036B0253 for ; Tue, 14 Nov 2017 10:11:37 -0500 (EST) Received: by mail-wr0-f197.google.com with SMTP id j15so11270909wre.15 for ; Tue, 14 Nov 2017 07:11:37 -0800 (PST) Received: from Galois.linutronix.de (Galois.linutronix.de. [2a01:7a0:2:106d:700::1]) by mx.google.com with ESMTPS id f2si15248901wrg.341.2017.11.14.07.11.36 for (version=TLS1_2 cipher=AES128-SHA bits=128/128); Tue, 14 Nov 2017 07:11:36 -0800 (PST) Date: Tue, 14 Nov 2017 16:11:31 +0100 (CET) From: Thomas Gleixner Subject: Re: [PATCH] mm: drop hotplug lock from lru_add_drain_all In-Reply-To: Message-ID: References: <20171114135348.28704-1-mhocko@kernel.org> <20171114142347.syzyd6tlnpe2afur@dhcp22.suse.cz> <20171114143200.brmgskoqxjlrhrzx@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: owner-linux-mm@kvack.org List-ID: To: Michal Hocko Cc: Andrew Morton , Tejun Heo , Peter Zijlstra , Johannes Weiner , Mel Gorman , linux-mm@kvack.org, LKML On Tue, 14 Nov 2017, Thomas Gleixner wrote: > On Tue, 14 Nov 2017, Michal Hocko wrote: > > > On Tue 14-11-17 15:23:47, Michal Hocko wrote: > > [...] > > > +/* > > > + * Doesn't need any cpu hotplug locking because we do rely on per-cpu > > > + * kworkers being shut down before our page_alloc_cpu_dead callback is > > > + * executed on the offlined cpu > > > + */ > > > void lru_add_drain_all(void) > > > { > > > static DEFINE_MUTEX(lock); > > > > Ble the part of the comment didn't go through > > Looks good. With that added, feel free to add: Acked-by: Thomas Gleixner -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org