From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759012AbdKPJQF (ORCPT ); Thu, 16 Nov 2017 04:16:05 -0500 Received: from Galois.linutronix.de ([146.0.238.70]:45007 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933457AbdKPJPp (ORCPT ); Thu, 16 Nov 2017 04:15:45 -0500 Date: Thu, 16 Nov 2017 10:15:42 +0100 (CET) From: Thomas Gleixner To: Jarkko Sakkinen cc: platform-driver-x86@vger.kernel.org, LKML , Al Viro Subject: Re: [PATCH v5 09/11] fs/pipe.c: export create_pipe_files() and replace_fd() In-Reply-To: <20171113194528.28557-10-jarkko.sakkinen@linux.intel.com> Message-ID: References: <20171113194528.28557-1-jarkko.sakkinen@linux.intel.com> <20171113194528.28557-10-jarkko.sakkinen@linux.intel.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 13 Nov 2017, Jarkko Sakkinen wrote: + Cc: Al - Cc: that intel sgx list because it's moderated and spams my inbox with useless moderation mails. > Exported create_pipe_files() and replace_fd() because the SGX driver > needs to be able to setup pipes in order to communicate with the helper > process that hosts the Launch Enclave (LE). The pipe creation will be > done in the init-callback supplied to call_usermodehelper_setup(). > > The driver will use two pipes for communication with the LE hosting > process: > > * One for writing SIGSTRUCT blobs. > * One for reading EINITTOKEN blobs. Can you pretty please make sure that people who maintain the affected code are CC'd on your changes? > Signed-off-by: Jarkko Sakkinen > --- > fs/file.c | 1 + > fs/pipe.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/fs/file.c b/fs/file.c > index 1fc7fbbb4510..b1fa28919b22 100644 > --- a/fs/file.c > +++ b/fs/file.c > @@ -871,6 +871,7 @@ int replace_fd(unsigned fd, struct file *file, unsigned flags) > spin_unlock(&files->file_lock); > return err; > } > +EXPORT_SYMBOL_GPL(replace_fd); > > SYSCALL_DEFINE3(dup3, unsigned int, oldfd, unsigned int, newfd, int, flags) > { > diff --git a/fs/pipe.c b/fs/pipe.c > index 97e5be897753..ee33a84127e7 100644 > --- a/fs/pipe.c > +++ b/fs/pipe.c > @@ -784,6 +784,7 @@ int create_pipe_files(struct file **res, int flags) > iput(inode); > return err; > } > +EXPORT_SYMBOL_GPL(create_pipe_files); > > static int __do_pipe_flags(int *fd, struct file **files, int flags) > { > -- > 2.14.1 > >