From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753523AbdKXNqS (ORCPT <rfc822;w@1wt.eu>);
        Fri, 24 Nov 2017 08:46:18 -0500
Received: from Galois.linutronix.de ([146.0.238.70]:47279 "EHLO
        Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752058AbdKXNqR (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 24 Nov 2017 08:46:17 -0500
Date: Fri, 24 Nov 2017 14:46:14 +0100 (CET)
From: Thomas Gleixner <tglx@linutronix.de>
To: Ingo Molnar <mingo@kernel.org>
cc: linux-kernel@vger.kernel.org,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Andy Lutomirski <luto@amacapital.net>,
        "H . Peter Anvin" <hpa@zytor.com>,
        Peter Zijlstra <peterz@infradead.org>, Borislav Petkov <bp@alien8.de>,
        Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH 14/43] x86/entry/64: Return to userspace from the trampoline
 stack
In-Reply-To: <20171124091448.7649-15-mingo@kernel.org>
Message-ID: <alpine.DEB.2.20.1711241445480.1757@nanos>
References: <20171124091448.7649-1-mingo@kernel.org> <20171124091448.7649-15-mingo@kernel.org>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 24 Nov 2017, Ingo Molnar wrote:

> From: Andy Lutomirski <luto@kernel.org>
> 
> By itself, this is useless.  It gives us the ability to run some final
> code before exit that cannnot run on the kernel stack.  This could
> include a CR3 switch a la KAISER or some kernel stack erasing, for
> example.  (Or even weird things like *changing* which kernel stack
> gets used as an ASLR-strengthening mechanism.)
> 
> The SYSRET32 path is not covered yet.  It could be in the future or
> we could just ignore it and force the slow path if needed.
> 
> Signed-off-by: Andy Lutomirski <luto@kernel.org>

Reviewed-by: Thomas Gleixner <tglx@linutronix.de>