From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751937AbdLFMMn (ORCPT ); Wed, 6 Dec 2017 07:12:43 -0500 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:50712 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751096AbdLFMMk (ORCPT ); Wed, 6 Dec 2017 07:12:40 -0500 X-IronPort-AV: E=Sophos;i="5.45,368,1508796000"; d="scan'208";a="304226173" Date: Wed, 6 Dec 2017 13:12:32 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: SF Markus Elfring cc: linux-usb@vger.kernel.org, Felipe Balbi , Greg Kroah-Hartman , Johan Hovold , LKML , kernel-janitors@vger.kernel.org Subject: Re: [PATCH] USB: emi26: Delete an error message for a failed memory allocation in emi26_writememory() In-Reply-To: <244f8baf-0cd7-89f5-b210-7c321e180f11@users.sourceforge.net> Message-ID: References: <244f8baf-0cd7-89f5-b210-7c321e180f11@users.sourceforge.net> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 6 Dec 2017, SF Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 6 Dec 2017 13:03:21 +0100 > > Omit an extra message for a memory allocation failure in this function. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > drivers/usb/misc/emi26.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/usb/misc/emi26.c b/drivers/usb/misc/emi26.c > index 24d841850e05..654e93857d65 100644 > --- a/drivers/usb/misc/emi26.c > +++ b/drivers/usb/misc/emi26.c > @@ -42,10 +42,9 @@ static int emi26_writememory (struct usb_device *dev, int address, > int result; > unsigned char *buffer = kmemdup(data, length, GFP_KERNEL); > > - if (!buffer) { > - dev_err(&dev->dev, "kmalloc(%d) failed.\n", length); I guess the length information would not be so easy to find in the backtrace. julia > + if (!buffer) > return -ENOMEM; > - } > + > /* Note: usb_control_msg returns negative value on error or length of the > * data that was written! */ > result = usb_control_msg (dev, usb_sndctrlpipe(dev, 0), request, 0x40, address, 0, buffer, length, 300); > -- > 2.15.1 > > -- > To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julia Lawall Date: Wed, 06 Dec 2017 12:12:32 +0000 Subject: Re: [PATCH] USB: emi26: Delete an error message for a failed memory allocation in emi26_writememory( Message-Id: List-Id: References: <244f8baf-0cd7-89f5-b210-7c321e180f11@users.sourceforge.net> In-Reply-To: <244f8baf-0cd7-89f5-b210-7c321e180f11@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: SF Markus Elfring Cc: linux-usb@vger.kernel.org, Felipe Balbi , Greg Kroah-Hartman , Johan Hovold , LKML , kernel-janitors@vger.kernel.org On Wed, 6 Dec 2017, SF Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 6 Dec 2017 13:03:21 +0100 > > Omit an extra message for a memory allocation failure in this function. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > drivers/usb/misc/emi26.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/usb/misc/emi26.c b/drivers/usb/misc/emi26.c > index 24d841850e05..654e93857d65 100644 > --- a/drivers/usb/misc/emi26.c > +++ b/drivers/usb/misc/emi26.c > @@ -42,10 +42,9 @@ static int emi26_writememory (struct usb_device *dev, int address, > int result; > unsigned char *buffer = kmemdup(data, length, GFP_KERNEL); > > - if (!buffer) { > - dev_err(&dev->dev, "kmalloc(%d) failed.\n", length); I guess the length information would not be so easy to find in the backtrace. julia > + if (!buffer) > return -ENOMEM; > - } > + > /* Note: usb_control_msg returns negative value on error or length of the > * data that was written! */ > result = usb_control_msg (dev, usb_sndctrlpipe(dev, 0), request, 0x40, address, 0, buffer, length, 300); > -- > 2.15.1 > > -- > To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: USB: emi26: Delete an error message for a failed memory allocation in emi26_writememory() From: Julia Lawall Message-Id: Date: Wed, 6 Dec 2017 13:12:32 +0100 (CET) To: SF Markus Elfring Cc: linux-usb@vger.kernel.org, Felipe Balbi , Greg Kroah-Hartman , Johan Hovold , LKML , kernel-janitors@vger.kernel.org List-ID: T24gV2VkLCA2IERlYyAyMDE3LCBTRiBNYXJrdXMgRWxmcmluZyB3cm90ZToKCj4gRnJvbTogTWFy a3VzIEVsZnJpbmcgPGVsZnJpbmdAdXNlcnMuc291cmNlZm9yZ2UubmV0Pgo+IERhdGU6IFdlZCwg NiBEZWMgMjAxNyAxMzowMzoyMSArMDEwMAo+Cj4gT21pdCBhbiBleHRyYSBtZXNzYWdlIGZvciBh IG1lbW9yeSBhbGxvY2F0aW9uIGZhaWx1cmUgaW4gdGhpcyBmdW5jdGlvbi4KPgo+IFRoaXMgaXNz dWUgd2FzIGRldGVjdGVkIGJ5IHVzaW5nIHRoZSBDb2NjaW5lbGxlIHNvZnR3YXJlLgo+Cj4gU2ln bmVkLW9mZi1ieTogTWFya3VzIEVsZnJpbmcgPGVsZnJpbmdAdXNlcnMuc291cmNlZm9yZ2UubmV0 Pgo+IC0tLQo+ICBkcml2ZXJzL3VzYi9taXNjL2VtaTI2LmMgfCA1ICsrLS0tCj4gIDEgZmlsZSBj aGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy91c2IvbWlzYy9lbWkyNi5jIGIvZHJpdmVycy91c2IvbWlzYy9lbWkyNi5jCj4gaW5k ZXggMjRkODQxODUwZTA1Li42NTRlOTM4NTdkNjUgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy91c2Iv bWlzYy9lbWkyNi5jCj4gKysrIGIvZHJpdmVycy91c2IvbWlzYy9lbWkyNi5jCj4gQEAgLTQyLDEw ICs0Miw5IEBAIHN0YXRpYyBpbnQgZW1pMjZfd3JpdGVtZW1vcnkgKHN0cnVjdCB1c2JfZGV2aWNl ICpkZXYsIGludCBhZGRyZXNzLAo+ICAJaW50IHJlc3VsdDsKPiAgCXVuc2lnbmVkIGNoYXIgKmJ1 ZmZlciA9ICBrbWVtZHVwKGRhdGEsIGxlbmd0aCwgR0ZQX0tFUk5FTCk7Cj4KPiAtCWlmICghYnVm ZmVyKSB7Cj4gLQkJZGV2X2VycigmZGV2LT5kZXYsICJrbWFsbG9jKCVkKSBmYWlsZWQuXG4iLCBs ZW5ndGgpOwoKSSBndWVzcyB0aGUgbGVuZ3RoIGluZm9ybWF0aW9uIHdvdWxkIG5vdCBiZSBzbyBl YXN5IHRvIGZpbmQgaW4gdGhlCmJhY2t0cmFjZS4KCmp1bGlhCgoKPiArCWlmICghYnVmZmVyKQo+ ICAJCXJldHVybiAtRU5PTUVNOwo+IC0JfQo+ICsKPiAgCS8qIE5vdGU6IHVzYl9jb250cm9sX21z ZyByZXR1cm5zIG5lZ2F0aXZlIHZhbHVlIG9uIGVycm9yIG9yIGxlbmd0aCBvZiB0aGUKPiAgCSAq IAkJIGRhdGEgdGhhdCB3YXMgd3JpdHRlbiEgKi8KPiAgCXJlc3VsdCA9IHVzYl9jb250cm9sX21z ZyAoZGV2LCB1c2Jfc25kY3RybHBpcGUoZGV2LCAwKSwgcmVxdWVzdCwgMHg0MCwgYWRkcmVzcywg MCwgYnVmZmVyLCBsZW5ndGgsIDMwMCk7Cj4gLS0KPiAyLjE1LjEKPgo+IC0tCj4gVG8gdW5zdWJz Y3JpYmUgZnJvbSB0aGlzIGxpc3Q6IHNlbmQgdGhlIGxpbmUgInVuc3Vic2NyaWJlIGtlcm5lbC1q YW5pdG9ycyIgaW4KPiB0aGUgYm9keSBvZiBhIG1lc3NhZ2UgdG8gbWFqb3Jkb21vQHZnZXIua2Vy bmVsLm9yZwo+IE1vcmUgbWFqb3Jkb21vIGluZm8gYXQgIGh0dHA6Ly92Z2VyLmtlcm5lbC5vcmcv bWFqb3Jkb21vLWluZm8uaHRtbAo+Ci0tLQpUbyB1bnN1YnNjcmliZSBmcm9tIHRoaXMgbGlzdDog c2VuZCB0aGUgbGluZSAidW5zdWJzY3JpYmUgbGludXgtdXNiIiBpbgp0aGUgYm9keSBvZiBhIG1l c3NhZ2UgdG8gbWFqb3Jkb21vQHZnZXIua2VybmVsLm9yZwpNb3JlIG1ham9yZG9tbyBpbmZvIGF0 ICBodHRwOi8vdmdlci5rZXJuZWwub3JnL21ham9yZG9tby1pbmZvLmh0bWwK