All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christopher Lameter <cl@linux.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Pekka Enberg <penberg@kernel.org>,
	David Rientjes <rientjes@google.com>,
	Joonsoo Kim <iamjoonsoo.kim@lge.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	"Tobin C . Harding" <me@tobin.cc>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH] mm/slab: Do not hash pointers when debugging slab
Date: Thu, 7 Dec 2017 05:13:56 -0600 (CST)	[thread overview]
Message-ID: <alpine.DEB.2.20.1712070512120.7218@nuc-kabylake> (raw)
In-Reply-To: <1512641861-5113-1-git-send-email-geert+renesas@glider.be>

On Thu, 7 Dec 2017, Geert Uytterhoeven wrote:

> If CONFIG_DEBUG_SLAB/CONFIG_DEBUG_SLAB_LEAK are enabled, the slab code
> prints extra debug information when e.g. corruption is detected.
> This includes pointers, which are not very useful when hashed.
>
> Fix this by using %px to print unhashed pointers instead.

Acked-by: Christoph Lameter <cl@linux.com>

These SLAB config options are only used for testing so this is ok.

WARNING: multiple messages have this Message-ID
From: Christopher Lameter <cl@linux.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Pekka Enberg <penberg@kernel.org>,
	David Rientjes <rientjes@google.com>,
	Joonsoo Kim <iamjoonsoo.kim@lge.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	"Tobin C . Harding" <me@tobin.cc>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH] mm/slab: Do not hash pointers when debugging slab
Date: Thu, 7 Dec 2017 05:13:56 -0600 (CST)	[thread overview]
Message-ID: <alpine.DEB.2.20.1712070512120.7218@nuc-kabylake> (raw)
In-Reply-To: <1512641861-5113-1-git-send-email-geert+renesas@glider.be>

On Thu, 7 Dec 2017, Geert Uytterhoeven wrote:

> If CONFIG_DEBUG_SLAB/CONFIG_DEBUG_SLAB_LEAK are enabled, the slab code
> prints extra debug information when e.g. corruption is detected.
> This includes pointers, which are not very useful when hashed.
>
> Fix this by using %px to print unhashed pointers instead.

Acked-by: Christoph Lameter <cl@linux.com>

These SLAB config options are only used for testing so this is ok.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2017-12-07 11:13 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-07 10:17 Geert Uytterhoeven
2017-12-07 11:13 ` Christopher Lameter [this message]
2017-12-07 11:13   ` Christopher Lameter
2017-12-07 18:43   ` Kees Cook
2017-12-07 18:43     ` Kees Cook
2017-12-07 20:15     ` Christopher Lameter
2017-12-07 20:15       ` Christopher Lameter
2017-12-10 20:45 ` Linus Torvalds
2017-12-10 20:45   ` Linus Torvalds
2017-12-11  8:08   ` Geert Uytterhoeven
2017-12-11  8:08     ` Geert Uytterhoeven
2017-12-11 12:00   ` Christopher Lameter
2017-12-11 12:00     ` Christopher Lameter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.1712070512120.7218@nuc-kabylake \
    --to=cl@linux.com \
    --cc=akpm@linux-foundation.org \
    --cc=geert+renesas@glider.be \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=me@tobin.cc \
    --cc=penberg@kernel.org \
    --cc=rientjes@google.com \
    --subject='Re: [PATCH] mm/slab: Do not hash pointers when debugging slab' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.