From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753038AbdLWUdl (ORCPT ); Sat, 23 Dec 2017 15:33:41 -0500 Received: from Galois.linutronix.de ([146.0.238.70]:58846 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750842AbdLWUdk (ORCPT ); Sat, 23 Dec 2017 15:33:40 -0500 Date: Sat, 23 Dec 2017 21:33:37 +0100 (CET) From: Thomas Gleixner To: vcaputo@pengaru.com cc: Pavel Machek , linux-kernel Subject: Re: thinkpad x60: sound problems in 4.15-rc1 was Re: thinkpad x60: sound problems in 4.14.0-next-20171114 In-Reply-To: <20171223203741.q4hwq6i33cjf3dyg@shells.gnugeneration.com> Message-ID: References: <20171127184411.GA22165@amd> <20171214095730.GA6150@amd> <20171219020658.qpvxx7fqvrisezs6@shells.gnugeneration.com> <20171219045415.46croaosad656d5v@shells.gnugeneration.com> <20171219231256.dpizizz55o27op3s@shells.gnugeneration.com> <20171219232212.GA5177@amd> <20171220003610.vogk3wrke47drsfw@shells.gnugeneration.com> <20171223053700.xu2fdir32e4e6cd6@shells.gnugeneration.com> <20171223203741.q4hwq6i33cjf3dyg@shells.gnugeneration.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 23 Dec 2017, vcaputo@pengaru.com wrote: > On Fri, Dec 22, 2017 at 09:37:01PM -0800, vcaputo@pengaru.com wrote: > Added the following instrumentation: > > diff --git a/arch/x86/kernel/apic/vector.c b/arch/x86/kernel/apic/vector.c > index 93edc2236282..7034eda4d494 100644 > --- a/arch/x86/kernel/apic/vector.c > +++ b/arch/x86/kernel/apic/vector.c > @@ -228,6 +228,9 @@ static int __assign_irq_vector(int irq, struct apic_chip_data *d, > cpumask_and(vector_searchmask, vector_searchmask, mask); > BUG_ON(apic->cpu_mask_to_apicid(vector_searchmask, irqdata, > &d->cfg.dest_apicid)); > + > + printk("allocated vector=%i maskfirst=%i\n", d->cfg.vector, cpumask_first(vector_searchmask)); > + > return 0; > } > > This is what I see: > > Upon playing song in cmus (on AC power since boot): > Dec 22 22:26:52 iridesce kernel: allocated vector=35 maskfirst=1 > > Yank AC: > Dec 22 22:27:14 iridesce kernel: allocated vector=51 maskfirst=1 > Dec 22 22:27:15 iridesce kernel: do_IRQ: 0.35 No irq handler for vector > > So CPU 0 vector 35 got an interrupt when maskfirst=1 for 35 as seen in > the added printk. > > It seems like the affinity changes are assuming a strict adherence to > the CPU mask when the underlying hardware is treating it more as a hint. > Perhaps handlers still need to be maintained on all CPUs in a given apic > domain, regardless of what the masks are configured as, to cover these > situations. That's odd. I'll have a look after the holidays. Merry Christmas! Thanks, tglx