From mboxrd@z Thu Jan  1 00:00:00 1970
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753230AbeAFTxy (ORCPT <rfc822;ralf@linux-mips.org> + 1 other);
        Sat, 6 Jan 2018 14:53:54 -0500
Received: from Galois.linutronix.de ([146.0.238.70]:46683 "EHLO
        Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752231AbeAFTxw (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 6 Jan 2018 14:53:52 -0500
Date: Sat, 6 Jan 2018 20:53:48 +0100 (CET)
From: Thomas Gleixner <tglx@linutronix.de>
To: Linus Torvalds <torvalds@linux-foundation.org>
cc: David Woodhouse <dwmw@amazon.co.uk>,
        Andi Kleen <ak@linux.intel.com>, Paul Turner <pjt@google.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Greg Kroah-Hartman <gregkh@linux-foundation.org>,
        Tim Chen <tim.c.chen@linux.intel.com>,
        Dave Hansen <dave.hansen@intel.com>,
        Kees Cook <keescook@google.com>,
        Rik van Riel <riel@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Andy Lutomirski <luto@amacapital.net>,
        Jiri Kosina <jikos@kernel.org>,
        One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH v5 05/12] x86/retpoline/ftrace: Convert ftrace assembler
 indirect jumps
In-Reply-To: <CA+55aFzTj8NgE7LAXjpOoQj6RM9Zh7WNdweFUiuUmHTJ7Xmm+w@mail.gmail.com>
Message-ID: <alpine.DEB.2.20.1801062050470.2376@nanos>
References: <1515239374-23361-1-git-send-email-dwmw@amazon.co.uk> <1515239374-23361-6-git-send-email-dwmw@amazon.co.uk> <CA+55aFzTj8NgE7LAXjpOoQj6RM9Zh7WNdweFUiuUmHTJ7Xmm+w@mail.gmail.com>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
X-Linutronix-Spam-Score: -1.0
X-Linutronix-Spam-Level: -
X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required,  ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>

On Sat, 6 Jan 2018, Linus Torvalds wrote:

> On Sat, Jan 6, 2018 at 3:49 AM, David Woodhouse <dwmw@amazon.co.uk> wrote:
> >
> > -       call    *ftrace_trace_function
> > +       movl    ftrace_trace_function, %ecx
> > +       NOSPEC_CALL %ecx
> 
> Can't we just do
> 
>     NOSPEC_CALL ftrace_trace_function
> 
> now?
> 
> [ Goes off and looks ]
> 
> Oh. The AMD lfence version wants a register. Oh well.

The register load could be put into the macro itself, though we need to
supply a scratch register

     NOSPEC_CALL ftrace_trace_function scratch_reg=%ecx

Whether thats much better, I don't know.

Thanks,

	tglx