From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752435AbeANWNX (ORCPT + 1 other); Sun, 14 Jan 2018 17:13:23 -0500 Received: from Galois.linutronix.de ([146.0.238.70]:38599 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751128AbeANWNW (ORCPT ); Sun, 14 Jan 2018 17:13:22 -0500 Date: Sun, 14 Jan 2018 23:13:19 +0100 (CET) From: Thomas Gleixner To: Sebastian Andrzej Siewior cc: Anna-Maria Gleixner , LKML , Peter Zijlstra , Ingo Molnar , keescook@chromium.org, Christoph Hellwig , John Stultz Subject: Re: [PATCH v5 01/36] timers: Use static keys for migrate_enable/nohz_active In-Reply-To: <20171222154501.qd7gzdqquwp3gwlh@breakpoint.cc> Message-ID: References: <20171221104205.7269-1-anna-maria@linutronix.de> <20171221104205.7269-2-anna-maria@linutronix.de> <20171222154501.qd7gzdqquwp3gwlh@breakpoint.cc> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Fri, 22 Dec 2017, Sebastian Andrzej Siewior wrote: > - if (!IS_ENABLED(CONFIG_NO_HZ_COMMON) || !base->nohz_active) > + if (!is_timers_nohz_active()) That's wrong. You are undoing the mainline changes. I'll send an updated one. Thanks, tglx