All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Meelis Roos <mroos@linux.ee>
Cc: Linux Kernel list <linux-kernel@vger.kernel.org>, x86@kernel.org
Subject: Re: 4.15: WARNING: CPU: 3 PID: 258 at kernel/irq/chip.c:244 __irq_startup+0x80/0x100
Date: Wed, 31 Jan 2018 08:58:32 +0100 (CET)	[thread overview]
Message-ID: <alpine.DEB.2.20.1801310856390.2293@nanos> (raw)
In-Reply-To: <alpine.LRH.2.21.1801302127080.11640@math.ut.ee>

[-- Attachment #1: Type: text/plain, Size: 646 bytes --]

On Wed, 31 Jan 2018, Meelis Roos wrote:
> > > Your supply of vintage hardware is amazing.
> 
> :-)
> 
> > Does the patch below fix the issue for you?
> 
>   CC      kernel/irq/autoprobe.o
> kernel/irq/autoprobe.c: In function ‘probe_irq_on’:
> kernel/irq/autoprobe.c:74:8: error: void value not ignored as it ought to be
>     if (irq_activate_and_startup(desc, IRQ_NORESEND))
>         ^~~~~~~~~~~~~~~~~~~~~~~~

Duh.

> Just 
> irq_activate_and_startup(desc, IRQ_NORESEND);

Indeed. 

> cures the warning and at least the first bootup was working otherwise 
> too.

I'll do a proper fix and queue it so your museum is kept alive.

Thanks,

	tglx

  reply	other threads:[~2018-01-31  7:58 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-29 16:20 4.15: WARNING: CPU: 3 PID: 258 at kernel/irq/chip.c:244 __irq_startup+0x80/0x100 Meelis Roos
2018-01-29 16:35 ` Thomas Gleixner
2018-01-30 18:36   ` Thomas Gleixner
2018-01-31  7:21     ` Meelis Roos
2018-01-31  7:58       ` Thomas Gleixner [this message]
2018-01-31  8:09         ` Ingo Molnar
2018-01-31 11:23           ` Meelis Roos
2018-01-31 11:59             ` Ingo Molnar
2018-01-31  9:54     ` [tip:irq/urgent] genirq: Make legacy autoprobing work again tip-bot for Thomas Gleixner
2018-02-01  8:15       ` Geert Uytterhoeven
2018-02-01  9:56         ` Thomas Gleixner
2018-02-01 11:35         ` Arnd Bergmann
2018-02-01  9:58     ` tip-bot for Thomas Gleixner
2018-02-01 10:12     ` tip-bot for Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.1801310856390.2293@nanos \
    --to=tglx@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mroos@linux.ee \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.