From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030317AbeCAMLQ (ORCPT ); Thu, 1 Mar 2018 07:11:16 -0500 Received: from mail-io0-f169.google.com ([209.85.223.169]:40133 "EHLO mail-io0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030253AbeCAMLO (ORCPT ); Thu, 1 Mar 2018 07:11:14 -0500 X-Google-Smtp-Source: AG47ELu6oI7rinhXRTQwdgc3+j/i0J9g9fu/bLE4ke/3nVUE8brhttHUiMPZQam4xnZYao/nUw8yGg== Date: Thu, 1 Mar 2018 04:11:11 -0800 (PST) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Aaron Lu cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , Huang Ying , Dave Hansen , Kemi Wang , Tim Chen , Andi Kleen , Michal Hocko , Vlastimil Babka , Mel Gorman , Matthew Wilcox Subject: Re: [PATCH v4 1/3] mm/free_pcppages_bulk: update pcp->count inside In-Reply-To: <20180301062845.26038-2-aaron.lu@intel.com> Message-ID: References: <20180301062845.26038-1-aaron.lu@intel.com> <20180301062845.26038-2-aaron.lu@intel.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 1 Mar 2018, Aaron Lu wrote: > Matthew Wilcox found that all callers of free_pcppages_bulk() currently > update pcp->count immediately after so it's natural to do it inside > free_pcppages_bulk(). > > No functionality or performance change is expected from this patch. > > Suggested-by: Matthew Wilcox > Signed-off-by: Aaron Lu Acked-by: David Rientjes From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-f198.google.com (mail-io0-f198.google.com [209.85.223.198]) by kanga.kvack.org (Postfix) with ESMTP id 5BAA26B0006 for ; Thu, 1 Mar 2018 07:11:15 -0500 (EST) Received: by mail-io0-f198.google.com with SMTP id m19so5637641iob.13 for ; Thu, 01 Mar 2018 04:11:15 -0800 (PST) Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id 124sor2303198iow.118.2018.03.01.04.11.14 for (Google Transport Security); Thu, 01 Mar 2018 04:11:14 -0800 (PST) Date: Thu, 1 Mar 2018 04:11:11 -0800 (PST) From: David Rientjes Subject: Re: [PATCH v4 1/3] mm/free_pcppages_bulk: update pcp->count inside In-Reply-To: <20180301062845.26038-2-aaron.lu@intel.com> Message-ID: References: <20180301062845.26038-1-aaron.lu@intel.com> <20180301062845.26038-2-aaron.lu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: owner-linux-mm@kvack.org List-ID: To: Aaron Lu Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , Huang Ying , Dave Hansen , Kemi Wang , Tim Chen , Andi Kleen , Michal Hocko , Vlastimil Babka , Mel Gorman , Matthew Wilcox On Thu, 1 Mar 2018, Aaron Lu wrote: > Matthew Wilcox found that all callers of free_pcppages_bulk() currently > update pcp->count immediately after so it's natural to do it inside > free_pcppages_bulk(). > > No functionality or performance change is expected from this patch. > > Suggested-by: Matthew Wilcox > Signed-off-by: Aaron Lu Acked-by: David Rientjes -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org