From: Julia Lawall <julia.lawall@lip6.fr>
To: Nishka Dasgupta <nishka.dasgupta_ug18@ashoka.edu.in>
Cc: gregkh@linuxfoundation.org, outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH v2] staging: ks7010: Remove spaces after typecast to int
Date: Thu, 1 Mar 2018 21:04:26 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.20.1803012103480.3474@hadrien> (raw)
In-Reply-To: <1519931110-2763-1-git-send-email-nishka.dasgupta_ug18@ashoka.edu.in>
On Fri, 2 Mar 2018, Nishka Dasgupta wrote:
> Remove spaces after typecast. Issue found with checkpatch.
I don't see any spaces in the staging tree. Maybe a previous change of
yours added them, or maybe someone else already fixed the issue.
julia
>
> Signed-off-by: Nishka Dasgupta <nishka.dasgupta_ug18@ashoka.edu.in>
> ---
> Changes in v2:
> - Revert to typecasting after removing in version 1.
> - Remove space after typecasting.
>
> drivers/staging/ks7010/ks_wlan_net.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/ks7010/ks_wlan_net.c b/drivers/staging/ks7010/ks_wlan_net.c
> index 482af50..91acf87 100644
> --- a/drivers/staging/ks7010/ks_wlan_net.c
> +++ b/drivers/staging/ks7010/ks_wlan_net.c
> @@ -208,7 +208,7 @@ static int ks_wlan_set_freq(struct net_device *dev,
> /* for SLEEP MODE */
> /* If setting by frequency, convert to a channel */
> if ((fwrq->e == 1) &&
> - (fwrq->m >= (int) 2.412e8) && (fwrq->m <= (int) 2.487e8)) {
> + (fwrq->m >= (int)2.412e8) && (fwrq->m <= (int)2.487e8)) {
> int f = fwrq->m / 100000;
> int c = 0;
>
> --
> 1.9.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1519931110-2763-1-git-send-email-nishka.dasgupta_ug18%40ashoka.edu.in.
> For more options, visit https://groups.google.com/d/optout.
>
next prev parent reply other threads:[~2018-03-01 20:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-01 19:05 [PATCH v2] staging: ks7010: Remove spaces after typecast to int Nishka Dasgupta
2018-03-01 20:04 ` Julia Lawall [this message]
2018-03-01 21:20 ` Nishka Dasgupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1803012103480.3474@hadrien \
--to=julia.lawall@lip6.fr \
--cc=gregkh@linuxfoundation.org \
--cc=nishka.dasgupta_ug18@ashoka.edu.in \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.