Re: [Outreachy kernel] Re:

From: Julia Lawall <julia.lawall@lip6.fr>
To: Nishka Dasgupta <nishka.dasgupta_ug18@ashoka.edu.in>
Cc: gregkh@linuxfoundation.org, outreachy-kernel@googlegroups.com,
	 eric@anholt.net, stefan.wahren@i2se.com, f.fainelli@gmail.com,
	 rjui@broadcom.com, sbranden@broadcom.com,
	 bcm-kernel-feedback-list@broadcom.com
Subject: Re: [Outreachy kernel] Re:
Date: Thu, 1 Mar 2018 21:29:28 +0100 (CET)	[thread overview]
Message-ID: <alpine.DEB.2.20.1803012126130.3474@hadrien> (raw)
In-Reply-To: <1519935610-27428-1-git-send-email-nishka.dasgupta_ug18@ashoka.edu.in>

On Fri, 2 Mar 2018, Nishka Dasgupta wrote:

> This is with reference to your last email pointing out that you have no
> context for what I am responding to. Unfortunately, I have been unable
> to get mutt to load my inbox, so I could not and cannot quote text
> directly. I have done my best to reproduce the conversation below in a
> coherent fashion; nonetheless, I apologise for any persisting lack of
> clarity.
>
> An hour ago I submitted the following commit with respect to
> drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c: [PATCH v2]
> staging: vc04_services: bcm2835-camera: Add blank line
>
> Your reply: Checkpatch is wrong here, don't you think? Are you sure this
> is actually doing what you think it is?
>
> My reply: Checkpatch suggested two warnings for this file in consecutive
> lines: "static VCHI_CONNECTION_T *vchi_connection;" and "static
> VCHI_INSTANCE_T vchi_instance;". Both warnings said to add a blank line
> after the declaration. If checkpatch was wrong, is it okay if I submit a
> version 2 with a blank line only after "vchi_instance" and not below
> "*vchi_connection" (effectively undoing one of my commits)?
>
> Your response: First off, I have no context as to what you are
> responding to here, please always quote the email you are responding to
> properly.  Reviewers deal with hundreds of emails a day, and not having
> context for what you say doesn't really work :( Also, properly wrap your
> email lines at 72 columns, your email client should do this for you,
> right?  Please respond to the email with the correct context and I will
> be glad to respond.  Right now, I have no idea what you are referring
> to.
>
> (I am sorry for the suboptimal formatting. I think I managed to linewrap
> this email properly, however.) My question remains: may I submit a
> revised commit that effectively undoes the first "add blank line"
> commit, i.e. the one that added a line between "static VCHI_CONNECTION_T
> *vchi_connection" and "static VCHI_INSTANCE_T vchi_instance"?  Thank you
> for your time, and apologies again for the confusion.

You don't submit patches to fix the incorrect changes you have proposed
and that have not been integrated.  Just start with the original staging
tree and send patches against that.

You can use git rebase to remove a previous commit in your tree (read the
manual to find the proper options).  Or if you don't care about your tree,
you can remove it and start over.

julia

>
> Regards,
> Nishka Dasgupta
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1519935610-27428-1-git-send-email-nishka.dasgupta_ug18%40ashoka.edu.in.
> For more options, visit https://groups.google.com/d/optout.
>