From: David Rientjes <rientjes@google.com>
To: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Cc: peterz@infradead.org, mhocko@suse.com, mingo@redhat.com,
linux-kernel@vger.kernel.org, linux-mm@kvack.org, bp@suse.de,
tglx@linutronix.de
Subject: Re: [PATCH v2] lockdep: Show address of "struct lockdep_map" at print_lock().
Date: Tue, 27 Mar 2018 13:23:57 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.20.1803271323130.5082@chino.kir.corp.google.com> (raw)
In-Reply-To: <201803271941.GBE57310.tVSOJLQOFFOHFM@I-love.SAKURA.ne.jp>
On Tue, 27 Mar 2018, Tetsuo Handa wrote:
> Since "struct lockdep_map" is embedded into lock objects, we can know
> which instance of a lock object is acquired using hlock->instance field.
> This will help finding which threads are causing a lock contention.
>
> Currently, print_lock() is printing hlock->acquire_ip field in both
> "[<%px>]" and "%pS" format. But "[<%px>]" is little useful nowadays, for
> we use scripts/faddr2line which receives "%pS" for finding the location
> in the source code. And I want to reduce amount of output, for
> debug_show_all_locks() might print a lot.
>
> Therefore, this patch replaces "[<%px>]" for printing hlock->acquire_ip
> field with "%p" for printing hlock->instance field.
>
> [ 251.305475] 3 locks held by a.out/31106:
> [ 251.308949] #0: 00000000b0f753ba (&mm->mmap_sem){++++}, at: copy_process.part.41+0x10d5/0x1fe0
> [ 251.314283] #1: 00000000ef64d539 (&mm->mmap_sem/1){+.+.}, at: copy_process.part.41+0x10fe/0x1fe0
> [ 251.319618] #2: 00000000b41a282e (&mapping->i_mmap_rwsem){++++}, at: copy_process.part.41+0x12f2/0x1fe0
>
> Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Borislav Petkov <bp@suse.de>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: David Rientjes <rientjes@google.com>
> Cc: Michal Hocko <mhocko@suse.com>
Acked-by: David Rientjes <rientjes@google.com>
next prev parent reply other threads:[~2018-03-27 20:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-26 10:18 [PATCH] lockdep: Show address of "struct lockdep_map" at print_lock() Tetsuo Handa
2018-03-26 13:19 ` Michal Hocko
2018-03-26 13:20 ` Michal Hocko
2018-03-26 16:05 ` Peter Zijlstra
2018-03-26 20:58 ` Tetsuo Handa
2018-03-27 10:41 ` [PATCH v2] " Tetsuo Handa
2018-03-27 10:50 ` Michal Hocko
2018-03-27 20:23 ` David Rientjes [this message]
2018-03-29 10:26 ` Tetsuo Handa
2018-03-29 12:01 ` Peter Zijlstra
2018-03-29 12:45 ` [tip:locking/core] lockdep: Make the lock debug output more useful tip-bot for Tetsuo Handa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1803271323130.5082@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=bp@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=mingo@redhat.com \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.