From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Kurz Subject: Re: [PATCH v3 2/2] net: usb: asix88179_178a: de-duplicate code Date: Mon, 2 Apr 2018 15:21:08 +0000 (UTC) Message-ID: References: <20180402074349.12010-1-akurz@blala.de> <20180402074349.12010-2-akurz@blala.de> <86woxqq6uz.wl-marc.zyngier@arm.com> <20180402.101410.2105582698262762699.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Cc: marc.zyngier@arm.com, afd@ti.com, linux-usb@vger.kernel.org, netdev@vger.kernel.org, freddy@asix.com.tw To: David Miller Return-path: Received: from vs10.datenmanufaktur-hosting.net ([185.138.26.202]:50724 "EHLO vs81.iboxed.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751435AbeDBPV7 (ORCPT ); Mon, 2 Apr 2018 11:21:59 -0400 In-Reply-To: <20180402.101410.2105582698262762699.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: Hi Marc, David, with the v2 patch ("net: usb: asix88179_178a: de-duplicate code") I made an embarrasly stupid mistake of removing the wrong function. The v2 patch accidentially changed ax88179_link_reset() instead of ax88179_reset(). Hunk 6 of v2 ("net: usb: asix88179_178a: de-duplicate code") is just utterly wrong. ax88179_bind() and ax88179_reset() were the correct targets to be de-duplicated, as done in the v3 patch. Sorry for this, Alexander On Mon, 2 Apr 2018, David Miller wrote: > From: Marc Zyngier > Date: Mon, 02 Apr 2018 10:45:40 +0100 > > > What has changed between this patch and the previous one? Having a bit > > of a change-log would certainly help. Also, I would have appreciated a > > reply to the questions I had on v2 before you posted a third version. > > Agreed, and I'm not applying these patches until this is sorted out > and explained properly. > From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v3,2/2] net: usb: asix88179_178a: de-duplicate code From: Alexander Kurz Message-Id: Date: Mon, 2 Apr 2018 15:21:08 +0000 (UTC) To: David Miller Cc: marc.zyngier@arm.com, afd@ti.com, linux-usb@vger.kernel.org, netdev@vger.kernel.org, freddy@asix.com.tw List-ID: SGkgTWFyYywgRGF2aWQsCndpdGggdGhlIHYyIHBhdGNoICgibmV0OiB1c2I6IGFzaXg4ODE3OV8x NzhhOiBkZS1kdXBsaWNhdGUgY29kZSIpCkkgbWFkZSBhbiBlbWJhcnJhc2x5IHN0dXBpZCBtaXN0 YWtlIG9mIHJlbW92aW5nIHRoZSB3cm9uZyBmdW5jdGlvbi4KVGhlIHYyIHBhdGNoIGFjY2lkZW50 aWFsbHkgY2hhbmdlZCBheDg4MTc5X2xpbmtfcmVzZXQoKSBpbnN0ZWFkIG9mIApheDg4MTc5X3Jl c2V0KCkuIEh1bmsgNiBvZiB2MiAoIm5ldDogdXNiOiBhc2l4ODgxNzlfMTc4YTogZGUtZHVwbGlj YXRlIApjb2RlIikgaXMganVzdCB1dHRlcmx5IHdyb25nLgoKYXg4ODE3OV9iaW5kKCkgYW5kIGF4 ODgxNzlfcmVzZXQoKSB3ZXJlIHRoZSBjb3JyZWN0IHRhcmdldHMgdG8gYmUgCmRlLWR1cGxpY2F0 ZWQsIGFzIGRvbmUgaW4gdGhlIHYzIHBhdGNoLgoKU29ycnkgZm9yIHRoaXMsIEFsZXhhbmRlcgoK T24gTW9uLCAyIEFwciAyMDE4LCBEYXZpZCBNaWxsZXIgd3JvdGU6Cgo+IEZyb206IE1hcmMgWnlu Z2llciA8bWFyYy56eW5naWVyQGFybS5jb20+Cj4gRGF0ZTogTW9uLCAwMiBBcHIgMjAxOCAxMDo0 NTo0MCArMDEwMAo+IAo+ID4gV2hhdCBoYXMgY2hhbmdlZCBiZXR3ZWVuIHRoaXMgcGF0Y2ggYW5k IHRoZSBwcmV2aW91cyBvbmU/IEhhdmluZyBhIGJpdAo+ID4gb2YgYSBjaGFuZ2UtbG9nIHdvdWxk IGNlcnRhaW5seSBoZWxwLiBBbHNvLCBJIHdvdWxkIGhhdmUgYXBwcmVjaWF0ZWQgYQo+ID4gcmVw bHkgdG8gdGhlIHF1ZXN0aW9ucyBJIGhhZCBvbiB2MiBiZWZvcmUgeW91IHBvc3RlZCBhIHRoaXJk IHZlcnNpb24uCj4gCj4gQWdyZWVkLCBhbmQgSSdtIG5vdCBhcHBseWluZyB0aGVzZSBwYXRjaGVz IHVudGlsIHRoaXMgaXMgc29ydGVkIG91dAo+IGFuZCBleHBsYWluZWQgcHJvcGVybHkuCj4KLS0t ClRvIHVuc3Vic2NyaWJlIGZyb20gdGhpcyBsaXN0OiBzZW5kIHRoZSBsaW5lICJ1bnN1YnNjcmli ZSBsaW51eC11c2IiIGluCnRoZSBib2R5IG9mIGEgbWVzc2FnZSB0byBtYWpvcmRvbW9Admdlci5r ZXJuZWwub3JnCk1vcmUgbWFqb3Jkb21vIGluZm8gYXQgIGh0dHA6Ly92Z2VyLmtlcm5lbC5vcmcv bWFqb3Jkb21vLWluZm8uaHRtbAo=