From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julia Lawall Subject: [PATCH] mhi_bus: core: fix memdup.cocci warnings Date: Sat, 28 Apr 2018 09:23:19 +0200 (CEST) Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Return-path: Sender: linux-kernel-owner@vger.kernel.org Cc: Greg Kroah-Hartman , Arnd Bergmann , Sujeev Dias , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Tony Truong , kbuild-all@01.org List-Id: linux-arm-msm@vger.kernel.org From: Fengguang Wu Use kmemdup rather than duplicating its implementation Generated by: scripts/coccinelle/api/memdup.cocci Fixes: ec8245f7a36f ("mhi_bus: core: Add support for MHI host interface") CC: Sujeev Dias Signed-off-by: Fengguang Wu Signed-off-by: Julia Lawall --- url: https://github.com/0day-ci/linux/commits/Sujeev-Dias/mhi_bus-core-Add-support-for-MHI-host-interface/20180428-065959 :::::: branch date: 3 hours ago :::::: commit date: 3 hours ago mhi_boot.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/drivers/bus/mhi/core/mhi_boot.c +++ b/drivers/bus/mhi/core/mhi_boot.c @@ -504,7 +504,7 @@ void mhi_fw_load_worker(struct work_stru if (size > firmware->size) size = firmware->size; - buf = kmalloc(size, GFP_KERNEL); + buf = kmemdup(firmware->data, size, GFP_KERNEL); if (!buf) { MHI_ERR("Could not allocate memory for image\n"); release_firmware(firmware); @@ -512,7 +512,6 @@ void mhi_fw_load_worker(struct work_stru } /* load sbl image */ - memcpy(buf, firmware->data, size); ret = mhi_fw_load_sbl(mhi_cntrl, buf, size); kfree(buf); From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AB8JxZpNs/vR6m1kONUl/y9Uy00ORApzSBeo2G4og6TDSEZvqWytK6WfYnI8UpTCMaUITDFW/ftI ARC-Seal: i=1; a=rsa-sha256; t=1524900199; cv=none; d=google.com; s=arc-20160816; b=rKopaw8UflB3D8zcpSMDUZOUaiDlq5cHQCqMT3OEiI0cOEgQqZ4NPah71L5sobZF7E OaGsCZV4OwDLBza3tbDjOXPwV/n8I8lL6ErY053gm3C7xtTxAUhp3aSXAhsu9jfuhj3a r7iQWU+mBLwTvmLLbvHUboW4S+oS7zuZzxBA3xulZ/zG65Mm7RzO5xo28gxLHEOmsAGn 3AauprobAqytTznDA/33WJT/zwhv1D59B3xY/0YoRbhuTrlVDHCY9IMcNKeOP8dgTRH9 4ixlGufo12B50LQzxhK2Hx+1JJvB/vxBBzUuCIBTZtaHfNYgRiX1cwTCSpMPticNw8o5 WTaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:user-agent:message-id:subject:cc:to:from:date :arc-authentication-results; bh=yuke70q8wEYq6OZcGP1Wd3JHUAYYwjMbZn3ph4DEFwo=; b=L/ZKNZDMiiS1h6S7s4x4btt2gn7R0tkrH6TLVkD4fkaGkdYB1JVA5HRpQouF7qeDwa aA8x/exBRYa1aB5iv6n+9kbZy/j3woJBTNgRDnSkVMC27nV/AFzg5WFUilTxAfG7OzYk lU0WHc+F3s0LeYT8/ghxJ9aN1SaTl92hCaq6rP3x2wN8nOhQR07D5jtwfoTvgFPLoY7j l1TlLtZefeqh5GVvKc9I+MA2o7Jws/1Mwv5gYCdT+Lo71p/ZpJ2nGvrPn//NnBu0e9XX x9OcRDAKz28Sa6lkZQ3KNqIqahVjFjzLqs9j8faeeEFH2CZkeM36YjlsOYOhmAF0gk/b KH0Q== ARC-Authentication-Results: i=1; mx.google.com; spf=neutral (google.com: 192.134.164.83 is neither permitted nor denied by domain of julia.lawall@lip6.fr) smtp.mailfrom=julia.lawall@lip6.fr Authentication-Results: mx.google.com; spf=neutral (google.com: 192.134.164.83 is neither permitted nor denied by domain of julia.lawall@lip6.fr) smtp.mailfrom=julia.lawall@lip6.fr X-IronPort-AV: E=Sophos;i="5.49,338,1520895600"; d="scan'208";a="324880493" Date: Sat, 28 Apr 2018 09:23:19 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Sujeev Dias cc: Greg Kroah-Hartman , Arnd Bergmann , Sujeev Dias , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Tony Truong , kbuild-all@01.org Subject: [PATCH] mhi_bus: core: fix memdup.cocci warnings Message-ID: User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1598973751594094526?= X-GMAIL-MSGID: =?utf-8?q?1598973751594094526?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: From: Fengguang Wu Use kmemdup rather than duplicating its implementation Generated by: scripts/coccinelle/api/memdup.cocci Fixes: ec8245f7a36f ("mhi_bus: core: Add support for MHI host interface") CC: Sujeev Dias Signed-off-by: Fengguang Wu Signed-off-by: Julia Lawall --- url: https://github.com/0day-ci/linux/commits/Sujeev-Dias/mhi_bus-core-Add-support-for-MHI-host-interface/20180428-065959 :::::: branch date: 3 hours ago :::::: commit date: 3 hours ago mhi_boot.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/drivers/bus/mhi/core/mhi_boot.c +++ b/drivers/bus/mhi/core/mhi_boot.c @@ -504,7 +504,7 @@ void mhi_fw_load_worker(struct work_stru if (size > firmware->size) size = firmware->size; - buf = kmalloc(size, GFP_KERNEL); + buf = kmemdup(firmware->data, size, GFP_KERNEL); if (!buf) { MHI_ERR("Could not allocate memory for image\n"); release_firmware(firmware); @@ -512,7 +512,6 @@ void mhi_fw_load_worker(struct work_stru } /* load sbl image */ - memcpy(buf, firmware->data, size); ret = mhi_fw_load_sbl(mhi_cntrl, buf, size); kfree(buf);