All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julia Lawall <julia.lawall@lip6.fr>
To: Payal Kshirsagar <payal.s.kshirsagar.98@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [PATCH v3] [Outreachy kernel] staging: vt6655: spaces around operators
Date: Thu, 21 Mar 2019 10:09:37 +0100 (CET)	[thread overview]
Message-ID: <alpine.DEB.2.20.1903211008360.5292@hadrien> (raw)
In-Reply-To: <1553159257-3568-1-git-send-email-payal.s.kshirsagar.98@gmail.com>



On Thu, 21 Mar 2019, Payal Kshirsagar wrote:

> Add spaces around operators
>
> Signed-off-by: Payal Kshirsagar <payal.s.kshirsagar.98@gmail.com>
>
> In v1, prefer spaces around operator.
> In v2, 'prefer' changed to 'add'
> and in v3, changes are mentioned.

This v2, etc stuff goes below the --.  That way it will get dropped hen
the patch is committed.  The previous versions aren't present in git, so
the history about them isn't interesting any more.

julia

> ---
>  drivers/staging/vt6655/device_main.c |  2 +-
>  drivers/staging/vt6655/rf.c          | 26 ++++++++++++--------------
>  2 files changed, 13 insertions(+), 15 deletions(-)
>
> diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c
> index b370985..866d794 100644
> --- a/drivers/staging/vt6655/device_main.c
> +++ b/drivers/staging/vt6655/device_main.c
> @@ -592,7 +592,7 @@ static int device_init_rd1_ring(struct vnt_private *priv)
>  			goto err_free_rd;
>  		}
>
> -		desc->next = &priv->aRD1Ring[(i+1) % priv->opts.rx_descs1];
> +		desc->next = &priv->aRD1Ring[(i + 1) % priv->opts.rx_descs1];
>  		desc->next_desc = cpu_to_le32(curr + sizeof(struct vnt_rx_desc));
>  	}
>
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1553159257-3568-1-git-send-email-payal.s.kshirsagar.98%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>


      reply	other threads:[~2019-03-21  9:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-21  9:07 [PATCH v3] [Outreachy kernel] staging: vt6655: spaces around operators Payal Kshirsagar
2019-03-21  9:09 ` Julia Lawall [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.1903211008360.5292@hadrien \
    --to=julia.lawall@lip6.fr \
    --cc=outreachy-kernel@googlegroups.com \
    --cc=payal.s.kshirsagar.98@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.