Re: [Outreachy kernel] [PATCH] staging: netlogic: Remove unnecessary error print

[Julia Lawall <julia.lawall@lip6.fr>]

On Thu, 21 Mar 2019, Himadri Pandya wrote:

> Kmalloc normally produces a backtrace when there is not enough memory.
> So it is unnecessary to print an error message that provides only this
> information. Hence, remove pr_error() from memory allocation check.
> Issue found using Coccinelle.
>
> Signed-off-by: Himadri Pandya <himadri18.07@gmail.com>
> ---
>  drivers/staging/netlogic/xlr_net.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/staging/netlogic/xlr_net.c b/drivers/staging/netlogic/xlr_net.c
> index 8554fcf4321b..afba1248e100 100644
> --- a/drivers/staging/netlogic/xlr_net.c
> +++ b/drivers/staging/netlogic/xlr_net.c
> @@ -389,10 +389,8 @@ static void *xlr_config_spill(struct xlr_net_priv *priv, int reg_start_0,
>  	base = priv->base_addr;
>  	spill_size = size;
>  	spill = kmalloc(spill_size + SMP_CACHE_BYTES, GFP_ATOMIC);
> -	if (!spill) {
> -		pr_err("Unable to allocate memory for spill area!\n");
> +	if (!spill)
>  		return ZERO_SIZE_PTR;

This seems to be the only driver that uses ZERO_SIZE_PTR as the result for
kmalloc.  It could be worth looking into what happens to this value
afterwards.

julia

> -	}
>
>  	spill = PTR_ALIGN(spill, SMP_CACHE_BYTES);
>  	phys_addr = virt_to_phys(spill);
> --
> 2.17.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190321095717.24155-1-himadri18.07%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>