From: Thomas Gleixner <tglx@linutronix.de>
To: Frederic Weisbecker <frederic@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Chris Metcalf <cmetcalf@mellanox.com>,
Luiz Capitulino <lcapitulino@redhat.com>,
Christoph Lameter <cl@linux.com>,
"Paul E . McKenney" <paulmck@linux.vnet.ibm.com>,
Wanpeng Li <kernellwp@gmail.com>, Mike Galbraith <efault@gmx.de>,
Rik van Riel <riel@redhat.com>
Subject: Re: [PATCH 2/6] nohz: Allow to check if remote CPU tick is stopped
Date: Sat, 17 Feb 2018 11:27:00 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.21.1802171125270.1473@nanos.tec.linutronix.de> (raw)
In-Reply-To: <1518655694-8057-3-git-send-email-frederic@kernel.org>
On Thu, 15 Feb 2018, Frederic Weisbecker wrote:
> This check is racy but provides a good heuristic to determine whether
> a CPU may need a remote tick or not.
>
> +int tick_nohz_tick_stopped_cpu(int cpu)
s/int/bool/ but I'm not religious about that.
> +{
> + struct tick_sched *ts = per_cpu_ptr(&tick_cpu_sched, cpu);
> +
> + return ts->tick_stopped;
> +}
Other than that nit:
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
next prev parent reply other threads:[~2018-02-17 10:29 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-15 0:48 [PATCH 0/6] isolation: 1Hz residual tick offloading v6 Frederic Weisbecker
2018-02-15 0:48 ` [PATCH 1/6] sched: Rename init_rq_hrtick to hrtick_rq_init Frederic Weisbecker
2018-02-17 10:22 ` Thomas Gleixner
2018-02-15 0:48 ` [PATCH 2/6] nohz: Allow to check if remote CPU tick is stopped Frederic Weisbecker
2018-02-17 10:27 ` Thomas Gleixner [this message]
2018-02-15 0:48 ` [PATCH 3/6] sched/isolation: Isolate workqueues when "nohz_full=" is set Frederic Weisbecker
2018-02-17 10:31 ` Thomas Gleixner
2018-02-15 0:48 ` [PATCH 4/6] sched/isolation: Offload residual 1Hz scheduler tick Frederic Weisbecker
2018-02-17 10:50 ` Thomas Gleixner
2018-02-20 15:44 ` Frederic Weisbecker
2018-02-15 0:48 ` [PATCH 5/6] sched/nohz: Remove the 1 Hz tick code Frederic Weisbecker
2018-02-17 10:51 ` Thomas Gleixner
2018-02-15 0:48 ` [PATCH 6/6] sched/isolation: Update nohz documentation to explain tick offload Frederic Weisbecker
2018-02-17 10:53 ` Thomas Gleixner
2018-02-20 16:40 ` Frederic Weisbecker
2018-02-16 13:38 ` [PATCH 0/6] isolation: 1Hz residual tick offloading v6 Peter Zijlstra
-- strict thread matches above, loose matches on Subject: below --
2018-02-08 17:59 [PATCH 0/6] isolation: 1Hz residual tick offloading v5 Frederic Weisbecker
2018-02-08 17:59 ` [PATCH 2/6] nohz: Allow to check if remote CPU tick is stopped Frederic Weisbecker
2018-01-19 0:02 [GIT PULL] isolation: 1Hz residual tick offloading v4 Frederic Weisbecker
2018-01-19 0:02 ` [PATCH 2/6] nohz: Allow to check if remote CPU tick is stopped Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1802171125270.1473@nanos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=cl@linux.com \
--cc=cmetcalf@mellanox.com \
--cc=efault@gmx.de \
--cc=frederic@kernel.org \
--cc=kernellwp@gmail.com \
--cc=lcapitulino@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.