From: Thomas Gleixner <tglx@linutronix.de>
To: David Woodhouse <dwmw@amazon.co.uk>
Cc: karahmed@amazon.de, x86@kernel.org, kvm@vger.kernel.org,
torvalds@linux-foundation.org, pbonzini@redhat.com,
linux-kernel@vger.kernel.org, bp@alien8.de, peterz@infradead.org,
jmattson@google.com, rkrcmar@redhat.com,
arjan.van.de.ven@intel.com, dave.hansen@intel.com,
mingo@kernel.org
Subject: Re: [PATCH v3 3/4] Revert "x86/retpoline: Simplify vmexit_fill_RSB()"
Date: Tue, 20 Feb 2018 09:35:25 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.21.1802200935050.24268@nanos.tec.linutronix.de> (raw)
In-Reply-To: <1519037457-7643-4-git-send-email-dwmw@amazon.co.uk>
On Mon, 19 Feb 2018, David Woodhouse wrote:
> This reverts commit 1dde7415e99933bb7293d6b2843752cbdb43ec11. By putting
> the RSB filling out of line and calling it, we waste one RSB slot for
> returning from the function itself, which means one fewer actual function
> call we can make if we're doing the Skylake abomination of call-depth
> counting.
>
> It also changed the number of RSB stuffings we do on vmexit from 32,
> which was correct, to 16. Let's just stop with the bikeshedding; it
> didn't actually *fix* anything anyway.
>
> Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>
Acked-by: Thomas Gleixner <tglx@linutronix.de>
next prev parent reply other threads:[~2018-02-20 8:35 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-19 10:50 [PATCH v3 0/4] Speculation control improvements David Woodhouse
2018-02-19 10:50 ` [PATCH v3 1/4] x86/speculation: Use IBRS if available before calling into firmware David Woodhouse
2018-02-20 7:44 ` Thomas Gleixner
2018-02-20 10:29 ` [tip:x86/pti] " tip-bot for David Woodhouse
2018-02-19 10:50 ` [PATCH v3 2/4] x86/speculation: Support "Enhanced IBRS" on future CPUs David Woodhouse
2018-02-20 8:31 ` Thomas Gleixner
2018-02-20 8:53 ` David Woodhouse
2018-02-20 10:37 ` Thomas Gleixner
2018-02-20 10:42 ` Thomas Gleixner
2018-02-20 11:22 ` David Woodhouse
2018-02-20 11:28 ` Paolo Bonzini
2018-02-26 19:55 ` Thomas Gleixner
2018-02-20 11:26 ` Paolo Bonzini
2018-02-19 10:50 ` [PATCH v3 3/4] Revert "x86/retpoline: Simplify vmexit_fill_RSB()" David Woodhouse
2018-02-20 8:35 ` Thomas Gleixner [this message]
2018-02-20 10:28 ` [tip:x86/pti] " tip-bot for David Woodhouse
2018-02-19 10:50 ` [PATCH v3 4/4] x86/retpoline: Support retpoline build with Clang David Woodhouse
2018-02-20 8:36 ` Thomas Gleixner
2018-02-20 8:45 ` David Woodhouse
2018-02-20 10:29 ` [tip:x86/pti] x86/retpoline: Support retpoline builds " tip-bot for David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1802200935050.24268@nanos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=arjan.van.de.ven@intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@intel.com \
--cc=dwmw@amazon.co.uk \
--cc=jmattson@google.com \
--cc=karahmed@amazon.de \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=rkrcmar@redhat.com \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.