From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <tglx@linutronix.de>
Received: from p5492e61e.dip0.t-ipconnect.de ([84.146.230.30]
 helo=nanos.glx-home)	by Galois.linutronix.de with esmtpsa
 (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256)	(Exim 4.80)	(envelope-from
 <tglx@linutronix.de>)	id 1fE7ZI-0001eX-Co	for speck@linutronix.de; Thu, 03
 May 2018 08:18:16 +0200
Date: Thu, 3 May 2018 08:18:16 +0200 (CEST)
From: Thomas Gleixner <tglx@linutronix.de>
Subject: Re: SBB V10 Bundle
In-Reply-To: <20180503060715.pbit46ttgwjfbi4e@gmail.com>
Message-ID: <alpine.DEB.2.21.1805030816590.1577@nanos.tec.linutronix.de>
References: <alpine.DEB.2.21.1805020051330.1596@nanos.tec.linutronix.de>
 <20180502120716.ohnwlckp7qi7njs3@gmail.com>
 <alpine.DEB.2.21.1805021508230.1560@nanos.tec.linutronix.de>
 <20180503060715.pbit46ttgwjfbi4e@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
To: speck@linutronix.de
List-ID: <speck.linutronix.de>

On Thu, 3 May 2018, speck for Ingo Molnar wrote:

> 
> * speck for Thomas Gleixner <speck@linutronix.de> wrote:
> 
> > > ==============>
> > > b4fe2032d782: prctl: Add speculation control prctls
> > > 
> > > +/* Per task speculation control */
> > > +#define PR_SET_SPECULATION_CTRL                52
> > > +#define PR_GET_SPECULATION_CTRL                53
> > > 
> > > Please flip this around, i.e.:
> > > 
> > >   /* Per task speculation control */
> > >   #define PR_GET_SPECULATION_CTRL                52
> > >   #define PR_SET_SPECULATION_CTRL                53
> > > 
> > > because GET/SET is the canonical ABI order, used in most early prctl()s as well, 
> > > until someone messed it up in PR_SET_TIMERSLACK, which bad example then everyone 
> > > after that cargo-cult-copied ... Let's go back to the original ABI sanity.
> 
> JFYI, you didn't reply to this one - forgot to reply?

Why so, I didn't disagree and fixed it. Like other stuff :)