From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Gleixner Subject: Re: [PATCH] x86/crypto: Add missing RETs Date: Sun, 24 Jun 2018 09:12:35 +0200 (CEST) Message-ID: References: <20180507213755.GA32406@avx2> <1529235613.4572.7.camel@gmx.de> <20180617120012.GB16877@zn.tnic> <1529242717.4472.3.camel@gmx.de> <1529244178.4674.1.camel@gmx.de> <20180617194747.GA21160@zn.tnic> <1529289279.31745.3.camel@gmx.de> <20180623103622.GA2760@zn.tnic> <20180624071105.GA29407@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Cc: Borislav Petkov , linux-crypto@vger.kernel.org, Mike Galbraith , Alexey Dobriyan , torvalds@linux-foundation.org, jpoimboe@redhat.com, luto@kernel.org, peterz@infradead.org, brgerst@gmail.com, hpa@zytor.com, linux-kernel@vger.kernel.org, dvlasenk@redhat.com, h.peter.anvin@intel.com, linux-tip-commits , Herbert Xu To: Ingo Molnar Return-path: In-Reply-To: <20180624071105.GA29407@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-crypto.vger.kernel.org On Sun, 24 Jun 2018, Ingo Molnar wrote: > * Borislav Petkov wrote: > > > Lemme send a proper patch now... > > > > --- > > From: Borislav Petkov > > Date: Sun, 17 Jun 2018 13:57:42 +0200 > > Subject: [PATCH] x86/crypto: Add missing RETs > > > > Add explicit RETs to the tail calls of AEGIS and MORUS crypto algorithms > > otherwise they run into INT3 padding due to > > > > 51bad67ffbce ("x86/asm: Pad assembly functions with INT3 instructions") > > > > leading to spurious debug exceptions. > > > > Mike Galbraith took care of all the remaining callsites. > > Note that 51bad67ffbce has been zapped because it caused too many problems like > this, but the explicit RETs make sense nevertheless. When applying the patch > please don't include the SHA1 of the non-upstream (and probably never-upstream) > commit. We should really have something like that exactly to catch cases like this. Thanks, tglx