From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E44DC43143 for ; Tue, 2 Oct 2018 06:21:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 42707208AE for ; Tue, 2 Oct 2018 06:21:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 42707208AE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726727AbeJBNCt (ORCPT ); Tue, 2 Oct 2018 09:02:49 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:58887 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726481AbeJBNCt (ORCPT ); Tue, 2 Oct 2018 09:02:49 -0400 Received: from p5492e4c1.dip0.t-ipconnect.de ([84.146.228.193] helo=nanos) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1g7E2x-0002oz-9u; Tue, 02 Oct 2018 08:20:39 +0200 Date: Tue, 2 Oct 2018 08:20:38 +0200 (CEST) From: Thomas Gleixner To: Mike Travis cc: Ingo Molnar , "H. Peter Anvin" , Hedi Berriche , Russ Anderson , Dimitri Sivanich , Borislav Petkov , Kate Stewart , Greg Kroah-Hartman , Philippe Ombredanne , Pavel Tatashin , Dave Hansen , Tom Lendacky , Ram Pai , Juergen Gross , "Kirill A. Shutemov" , Andi Kleen , Petr Tesarik , Sinan Kaya , x86@kernel.org, linux-kernel@vger.kernel.org, Hedi Berriche Subject: Re: [PATCH 1/2] x86/platform/uv: Add is_early_uv_system check In-Reply-To: <20181002012204.453928259@stormcage.americas.sgi.com> Message-ID: References: <20181002012204.297193336@stormcage.americas.sgi.com> <20181002012204.453928259@stormcage.americas.sgi.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 1 Oct 2018, Mike Travis wrote: > Introduce is_early_uv_system() which uses efi.uv_systab to decide early > in the boot process whether we're on a UV system. > > This is needed to skip other early setup/init code that might break UV > platform if done too early such as before necessary ACPI tables parsing > takes place. > > Signed-off-by: Mike Travis > Signed-off-by: Hedi Berriche This SOB chain is wrong. I don't see how Hedi is involved in this. If this wants to express that the patch was developed together please see Documentation for the Co-developed-by tag. > Reviewed-by: Russ Anderson > Reviewed-by: Dimitri Sivanich > --- > arch/x86/include/asm/uv/uv.h | 6 ++++++ > 1 file changed, 6 insertions(+) > > --- linux.orig/arch/x86/include/asm/uv/uv.h > +++ linux/arch/x86/include/asm/uv/uv.h > @@ -10,8 +10,13 @@ struct cpumask; > struct mm_struct; > > #ifdef CONFIG_X86_UV > +#include > > extern enum uv_system_type get_uv_system_type(void); > +static inline int is_early_uv_system(void) Can you please make this bool? > +{ > + return !((efi.uv_systab == EFI_INVALID_TABLE_ADDR) || !efi.uv_systab); > +} Thanks, tglx