On Wed, 3 Oct 2018, Dafna Hirschfeld wrote:

>
>
> On Wed, Oct 3, 2018 at 10:05 PM Julia Lawall <julia.lawall@lip6.fr> wrote:
>
>
>       On Wed, 3 Oct 2018, Dafna Hirschfeld wrote:
>
>       >
>       >
>       > On Wed, Oct 3, 2018 at 7:06 AM Julia Lawall
>       <julia.lawall@lip6.fr> wrote:
>       >       > > Then in run "make menuconfig" again and under
>       "Device
>       >       Drivers -> staging
>       >       > > drivers" I chose "MediaTek MT7621 PCI Controller"
>       >       > > Hoping it will solve it , but it didn't.
>       >       > >
>       >       > > The files I prepared the patchset for did compile ok
>       , is it
>       >       important that
>       >       > > all files will compile?
>       >       >
>       >       > I think for these changes just use that .config
>       supplied by
>       >       the distro
>       >       > at /boot/config-*
>       >       >
>       >       > But IIRC `make allyesconfig` should be used(not sure
>       though..)
>       >
>       >       Dafna,
>       >
>       >       It is important that the driver continues to compile.
>       >
>       > Hi,
>       > Fixing the compilation error
>       in drivers/staging/mt7621-pci/pci-mt7621.c is
>       > not triveal,
>       > It is not clear what type `port` and `tmp` should be.
>
>       pcie has a type.  I think it is possible to figure it out from
>       there.  YOu
>       can also see how port is used, for confirmation.
>
>       julia
>
> The code is:
>
> list_for_each_entry_safe(port, tmp, &pcie->ports, list) {
>                 u32 slot = port->slot;
>                 val = read_config(pcie, slot, 0x70c);
>                 dev_info(dev, "Port %d N_FTS = %x\n", (unsigned int)val,
> slot);
>         }
>
> where `pcie` is of type `struct mt7621_pcie*` and `pcie->ports` is `struct
> list_head`
> I guess `port` should be `struct mt7621_pcie_port` but this struct does not
> have a `slot` member.

Maybe there is code somewhere adding elements to the list?

As a last resort, you could write to the person who produced the patch,
and ask him what he had in mind.  It's possible that the code is just
copied from somewhere else, and doesn't make sense at all.

julia

>
> Dafna
>       >  
>       > Dafna
>       >
>       >       Make allyesconfig is often a good option.
>       >
>       >       julia
>       >
>       > --
>       > You received this message because you are subscribed to the
>       Google Groups
>       > "outreachy-kernel" group.
>       > To unsubscribe from this group and stop receiving emails from
>       it, send an
>       > email to outreachy-kernel+unsubscribe@googlegroups.com.
>       > To post to this group, send email to
>       outreachy-kernel@googlegroups.com.
>       > To view this discussion on the webvisithttps://groups.google.com/d/msgid/outreachy-kernel/CAJ1myNRF%2B1S%3Dep
>       CMJxU
>       > a1YrdPK4p80CiPn2FDdqw5mnwTq%2BmQA%40mail.gmail.com.
>       > For more options, visit https://groups.google.com/d/optout.
>       >
>       >
>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/CAJ1myNRTErSd_p5KdY6VvG9
> qu%2Be9R5QcAeJsfmO_aXkqL_SOxw%40mail.gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
>