All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julia Lawall <julia.lawall@lip6.fr>
To: Bhanusree Pola <bhanusreemahesh@gmail.com>
Cc: outreachy-kernel@googlegroups.com, abbotti@mev.co.uk,
	 gregkh@linuxfoundation.org, hsweeten@visionengravers.com
Subject: Re: [Outreachy kernel] [Outreachy Kernel][PATCH v5] staging:comedi:comedi_pci.h Prefer a maximum 75 chars per line
Date: Sat, 6 Oct 2018 21:06:51 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.21.1810062105410.2402@hadrien> (raw)
In-Reply-To: <20181006190246.GA14037@veda-VGN-CS3AGH-R>



On Sun, 7 Oct 2018, Bhanusree Pola wrote:

> Adjust all lines exceeding 75 chars per line to fix checkpatch warning.
>
> Signed-off-by: Bhanusree Pola <bhanusreemahesh@gmail.com>
> ---
>
> changes in v5:
> -Fixed Change log
> -Change in subject line.Do not send as 'Re:'

It doesn't matter here, because this text will go away, but please get in
the habit of putting at least one space after punctuation.  That is:

Change in subject line. Do not send as 'Re:'

Then things don't run together, and it is easier to read.

julia

>
> changes in v4:
> -Remove Whitespace in comment section of module_comedi_pci_driver()
>  to fix checkpatch Error.
>
> changes in v3:
> -Comment section of module_pci_driver() exceeds 75 characters.
>  Adjust the chars to 75 per line
> -Modified log message.
> -Added change log.
>
> changes in v2:
> -comedi_pci_auto_config() function prototype is exceeds
>  75 characters per line. Adjust to 75 chars to improve
>  readability and also adjust the arguments to match open
>  parantheses.
> -Comment section of module_comedi_pci_driver() exceeds 75
>  characters. Modified contents to adjust 75 chars per line.
>
>  drivers/staging/comedi/comedi_pci.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/comedi/comedi_pci.h b/drivers/staging/comedi/comedi_pci.h
> index 1cc5436cb415..7291d3c0b7dc 100644
> --- a/drivers/staging/comedi/comedi_pci.h
> +++ b/drivers/staging/comedi/comedi_pci.h
> @@ -42,7 +42,7 @@ void comedi_pci_driver_unregister(struct comedi_driver *comedi_driver,
>  				  struct pci_driver *pci_driver);
>
>  /**
> - * module_comedi_pci_driver()-Helper macro for registering a comedi PCI
> + * module_comedi_pci_driver()-Helper macro for registering a comedi PCI
>   * driver
>   * @__comedi_driver: comedi_driver struct
>   * @__pci_driver: pci_driver struct
> --
> 2.17.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20181006190246.GA14037%40veda-VGN-CS3AGH-R.
> For more options, visit https://groups.google.com/d/optout.
>


  reply	other threads:[~2018-10-06 19:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-06 19:02 [Outreachy Kernel][PATCH v5] staging:comedi:comedi_pci.h Prefer a maximum 75 chars per line Bhanusree Pola
2018-10-06 19:06 ` Julia Lawall [this message]
2018-10-06 19:13   ` [Outreachy kernel] " Bhanusree
2018-10-06 19:31 ` Himanshu Jha
2018-10-06 19:41   ` Julia Lawall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.21.1810062105410.2402@hadrien \
    --to=julia.lawall@lip6.fr \
    --cc=abbotti@mev.co.uk \
    --cc=bhanusreemahesh@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hsweeten@visionengravers.com \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.