From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A297DC6787C for ; Sun, 14 Oct 2018 08:17:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 46FA320835 for ; Sun, 14 Oct 2018 08:17:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 46FA320835 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726515AbeJNP5x (ORCPT ); Sun, 14 Oct 2018 11:57:53 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:53651 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726115AbeJNP5w (ORCPT ); Sun, 14 Oct 2018 11:57:52 -0400 Received: from p5492fe24.dip0.t-ipconnect.de ([84.146.254.36] helo=nanos) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1gBba5-0000FJ-No; Sun, 14 Oct 2018 10:16:57 +0200 Date: Sun, 14 Oct 2018 10:16:56 +0200 (CEST) From: Thomas Gleixner To: Liran Alon cc: lantianyu1986@gmail.com, Lan Tianyu , christoffer.dall@arm.com, marc.zyngier@arm.com, linux@armlinux.org, catalin.marinas@arm.com, will.deacon@arm.com, jhogan@kernel.org, ralf@linux-mips.org, paul.burton@mips.com, paulus@ozlabs.org, benh@kernel.crashing.org, mpe@ellerman.id.au, kys@microsoft.com, haiyangz@microsoft.com, sthemmin@microsoft.com, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, pbonzini@redhat.com, rkrcmar@redhat.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org, kvm-ppc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, devel@linuxdriverproject.org, kvm@vger.kernel.org, michael.h.kelley@microsoft.com, vkuznets@redhat.com Subject: Re: [PATCH V4 2/15] KVM/MMU: Add tlb flush with range helper function In-Reply-To: <4D709C3A-A91C-4CA7-922A-E77618EF21B4@oracle.com> Message-ID: References: <20181013145406.4911-1-Tianyu.Lan@microsoft.com> <20181013145406.4911-3-Tianyu.Lan@microsoft.com> <4D709C3A-A91C-4CA7-922A-E77618EF21B4@oracle.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-68457485-1539505017=:1438" X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-68457485-1539505017=:1438 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT On Sun, 14 Oct 2018, Liran Alon wrote: > > On 13 Oct 2018, at 17:53, lantianyu1986@gmail.com wrote: > > > > From: Lan Tianyu > > > > This patch is to add wrapper functions for tlb_remote_flush_with_range > > callback. > > > > Signed-off-by: Lan Tianyu > > --- > > Change sicne V3: > > Remove code of updating "tlbs_dirty" > > Change since V2: > > Fix comment in the kvm_flush_remote_tlbs_with_range() > > --- > > arch/x86/kvm/mmu.c | 40 ++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 40 insertions(+) > > > > diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c > > index c73d9f650de7..ff656d85903a 100644 > > --- a/arch/x86/kvm/mmu.c > > +++ b/arch/x86/kvm/mmu.c > > @@ -264,6 +264,46 @@ static void mmu_spte_set(u64 *sptep, u64 spte); > > static union kvm_mmu_page_role > > kvm_mmu_calc_root_page_role(struct kvm_vcpu *vcpu); > > > > + > > +static inline bool kvm_available_flush_tlb_with_range(void) > > +{ > > + return kvm_x86_ops->tlb_remote_flush_with_range; > > +} > > Seems that kvm_available_flush_tlb_with_range() is not used in this patch… What's wrong with that? It provides the implementation and later patches make use of it. It's a sensible way to split patches into small, self contained entities. Thanks, tglx --8323329-68457485-1539505017=:1438-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Gleixner Subject: Re: [PATCH V4 2/15] KVM/MMU: Add tlb flush with range helper function Date: Sun, 14 Oct 2018 10:16:56 +0200 (CEST) Message-ID: References: <20181013145406.4911-1-Tianyu.Lan@microsoft.com> <20181013145406.4911-3-Tianyu.Lan@microsoft.com> <4D709C3A-A91C-4CA7-922A-E77618EF21B4@oracle.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-68457485-1539505017=:1438" Cc: linux-mips@linux-mips.org, linux@armlinux.org, kvm@vger.kernel.org, catalin.marinas@arm.com, will.deacon@arm.com, linux-kernel@vger.kernel.org, paulus@ozlabs.org, hpa@zytor.com, kys@microsoft.com, kvmarm@lists.cs.columbia.edu, lantianyu1986@gmail.com, sthemmin@microsoft.com, mpe@ellerman.id.au, x86@kernel.org, michael.h.kelley@microsoft.com, mingo@redhat.com, benh@kernel.crashing.org, jhogan@kernel.org, Lan Tianyu , marc.zyngier@arm.com, haiyangz@microsoft.com, kvm-ppc@vger.kernel.org, devel@linuxdriverproject.org, linux-arm-kernel@lists.infradead.org, ralf@linux-mips.org, paul.burton@mips.com, pbonzini@redhat.com, vkuznets@redhat.com, linuxppc-dev@lists.ozlabs.org To: Liran Alon Return-path: In-Reply-To: <4D709C3A-A91C-4CA7-922A-E77618EF21B4@oracle.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu List-Id: kvm.vger.kernel.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-68457485-1539505017=:1438 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT On Sun, 14 Oct 2018, Liran Alon wrote: > > On 13 Oct 2018, at 17:53, lantianyu1986@gmail.com wrote: > > > > From: Lan Tianyu > > > > This patch is to add wrapper functions for tlb_remote_flush_with_range > > callback. > > > > Signed-off-by: Lan Tianyu > > --- > > Change sicne V3: > > Remove code of updating "tlbs_dirty" > > Change since V2: > > Fix comment in the kvm_flush_remote_tlbs_with_range() > > --- > > arch/x86/kvm/mmu.c | 40 ++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 40 insertions(+) > > > > diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c > > index c73d9f650de7..ff656d85903a 100644 > > --- a/arch/x86/kvm/mmu.c > > +++ b/arch/x86/kvm/mmu.c > > @@ -264,6 +264,46 @@ static void mmu_spte_set(u64 *sptep, u64 spte); > > static union kvm_mmu_page_role > > kvm_mmu_calc_root_page_role(struct kvm_vcpu *vcpu); > > > > + > > +static inline bool kvm_available_flush_tlb_with_range(void) > > +{ > > + return kvm_x86_ops->tlb_remote_flush_with_range; > > +} > > Seems that kvm_available_flush_tlb_with_range() is not used in this patch… What's wrong with that? It provides the implementation and later patches make use of it. It's a sensible way to split patches into small, self contained entities. Thanks, tglx --8323329-68457485-1539505017=:1438 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm --8323329-68457485-1539505017=:1438-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36087C6787C for ; Sun, 14 Oct 2018 08:19:36 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8E6A820835 for ; Sun, 14 Oct 2018 08:19:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8E6A820835 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linutronix.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 42Xvcj6C30zF3DQ for ; Sun, 14 Oct 2018 19:19:33 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=linutronix.de Authentication-Results: lists.ozlabs.org; spf=none (mailfrom) smtp.mailfrom=linutronix.de (client-ip=2a01:7a0:2:106d:700::1; helo=galois.linutronix.de; envelope-from=tglx@linutronix.de; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=linutronix.de Received: from Galois.linutronix.de (Galois.linutronix.de [IPv6:2a01:7a0:2:106d:700::1]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 42XvZV0RR2zDqC7 for ; Sun, 14 Oct 2018 19:17:38 +1100 (AEDT) Received: from p5492fe24.dip0.t-ipconnect.de ([84.146.254.36] helo=nanos) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1gBba5-0000FJ-No; Sun, 14 Oct 2018 10:16:57 +0200 Date: Sun, 14 Oct 2018 10:16:56 +0200 (CEST) From: Thomas Gleixner To: Liran Alon Subject: Re: [PATCH V4 2/15] KVM/MMU: Add tlb flush with range helper function In-Reply-To: <4D709C3A-A91C-4CA7-922A-E77618EF21B4@oracle.com> Message-ID: References: <20181013145406.4911-1-Tianyu.Lan@microsoft.com> <20181013145406.4911-3-Tianyu.Lan@microsoft.com> <4D709C3A-A91C-4CA7-922A-E77618EF21B4@oracle.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-68457485-1539505017=:1438" X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1, SHORTCIRCUIT=-0.0001 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-mips@linux-mips.org, linux@armlinux.org, kvm@vger.kernel.org, rkrcmar@redhat.com, catalin.marinas@arm.com, will.deacon@arm.com, linux-kernel@vger.kernel.org, hpa@zytor.com, kys@microsoft.com, kvmarm@lists.cs.columbia.edu, lantianyu1986@gmail.com, sthemmin@microsoft.com, x86@kernel.org, michael.h.kelley@microsoft.com, mingo@redhat.com, jhogan@kernel.org, Lan Tianyu , marc.zyngier@arm.com, haiyangz@microsoft.com, kvm-ppc@vger.kernel.org, devel@linuxdriverproject.org, linux-arm-kernel@lists.infradead.org, christoffer.dall@arm.com, ralf@linux-mips.org, paul.burton@mips.com, pbonzini@redhat.com, vkuznets@redhat.com, linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-68457485-1539505017=:1438 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT On Sun, 14 Oct 2018, Liran Alon wrote: > > On 13 Oct 2018, at 17:53, lantianyu1986@gmail.com wrote: > > > > From: Lan Tianyu > > > > This patch is to add wrapper functions for tlb_remote_flush_with_range > > callback. > > > > Signed-off-by: Lan Tianyu > > --- > > Change sicne V3: > > Remove code of updating "tlbs_dirty" > > Change since V2: > > Fix comment in the kvm_flush_remote_tlbs_with_range() > > --- > > arch/x86/kvm/mmu.c | 40 ++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 40 insertions(+) > > > > diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c > > index c73d9f650de7..ff656d85903a 100644 > > --- a/arch/x86/kvm/mmu.c > > +++ b/arch/x86/kvm/mmu.c > > @@ -264,6 +264,46 @@ static void mmu_spte_set(u64 *sptep, u64 spte); > > static union kvm_mmu_page_role > > kvm_mmu_calc_root_page_role(struct kvm_vcpu *vcpu); > > > > + > > +static inline bool kvm_available_flush_tlb_with_range(void) > > +{ > > + return kvm_x86_ops->tlb_remote_flush_with_range; > > +} > > Seems that kvm_available_flush_tlb_with_range() is not used in this patch… What's wrong with that? It provides the implementation and later patches make use of it. It's a sensible way to split patches into small, self contained entities. Thanks, tglx --8323329-68457485-1539505017=:1438-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: tglx@linutronix.de (Thomas Gleixner) Date: Sun, 14 Oct 2018 10:16:56 +0200 (CEST) Subject: [PATCH V4 2/15] KVM/MMU: Add tlb flush with range helper function In-Reply-To: <4D709C3A-A91C-4CA7-922A-E77618EF21B4@oracle.com> References: <20181013145406.4911-1-Tianyu.Lan@microsoft.com> <20181013145406.4911-3-Tianyu.Lan@microsoft.com> <4D709C3A-A91C-4CA7-922A-E77618EF21B4@oracle.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Sun, 14 Oct 2018, Liran Alon wrote: > > On 13 Oct 2018, at 17:53, lantianyu1986 at gmail.com wrote: > > > > From: Lan Tianyu > > > > This patch is to add wrapper functions for tlb_remote_flush_with_range > > callback. > > > > Signed-off-by: Lan Tianyu > > --- > > Change sicne V3: > > Remove code of updating "tlbs_dirty" > > Change since V2: > > Fix comment in the kvm_flush_remote_tlbs_with_range() > > --- > > arch/x86/kvm/mmu.c | 40 ++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 40 insertions(+) > > > > diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c > > index c73d9f650de7..ff656d85903a 100644 > > --- a/arch/x86/kvm/mmu.c > > +++ b/arch/x86/kvm/mmu.c > > @@ -264,6 +264,46 @@ static void mmu_spte_set(u64 *sptep, u64 spte); > > static union kvm_mmu_page_role > > kvm_mmu_calc_root_page_role(struct kvm_vcpu *vcpu); > > > > + > > +static inline bool kvm_available_flush_tlb_with_range(void) > > +{ > > + return kvm_x86_ops->tlb_remote_flush_with_range; > > +} > > Seems that kvm_available_flush_tlb_with_range() is not used in this patch? What's wrong with that? It provides the implementation and later patches make use of it. It's a sensible way to split patches into small, self contained entities. Thanks, tglx From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Gleixner Date: Sun, 14 Oct 2018 08:16:56 +0000 Subject: Re: [PATCH V4 2/15] KVM/MMU: Add tlb flush with range helper function Message-Id: MIME-Version: 1 Content-Type: multipart/mixed; boundary="8323329-68457485-1539505017=:1438" List-Id: References: <20181013145406.4911-1-Tianyu.Lan@microsoft.com> <20181013145406.4911-3-Tianyu.Lan@microsoft.com> <4D709C3A-A91C-4CA7-922A-E77618EF21B4@oracle.com> In-Reply-To: <4D709C3A-A91C-4CA7-922A-E77618EF21B4@oracle.com> To: Liran Alon Cc: lantianyu1986@gmail.com, Lan Tianyu , christoffer.dall@arm.com, marc.zyngier@arm.com, linux@armlinux.org, catalin.marinas@arm.com, will.deacon@arm.com, jhogan@kernel.org, ralf@linux-mips.org, paul.burton@mips.com, paulus@ozlabs.org, benh@kernel.crashing.org, mpe@ellerman.id.au, kys@microsoft.com, haiyangz@microsoft.com, sthemmin@microsoft.com, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, pbonzini@redhat.com, rkrcmar@redhat.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org, kvm-ppc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, devel@linuxdriverproject.org, kvm@vger.kernel.org, michael.h.kelley@microsoft.com, vkuznets@redhat.com This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-68457485-1539505017=:1438 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit On Sun, 14 Oct 2018, Liran Alon wrote: > > On 13 Oct 2018, at 17:53, lantianyu1986@gmail.com wrote: > > > > From: Lan Tianyu > > > > This patch is to add wrapper functions for tlb_remote_flush_with_range > > callback. > > > > Signed-off-by: Lan Tianyu > > --- > > Change sicne V3: > > Remove code of updating "tlbs_dirty" > > Change since V2: > > Fix comment in the kvm_flush_remote_tlbs_with_range() > > --- > > arch/x86/kvm/mmu.c | 40 ++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 40 insertions(+) > > > > diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c > > index c73d9f650de7..ff656d85903a 100644 > > --- a/arch/x86/kvm/mmu.c > > +++ b/arch/x86/kvm/mmu.c > > @@ -264,6 +264,46 @@ static void mmu_spte_set(u64 *sptep, u64 spte); > > static union kvm_mmu_page_role > > kvm_mmu_calc_root_page_role(struct kvm_vcpu *vcpu); > > > > + > > +static inline bool kvm_available_flush_tlb_with_range(void) > > +{ > > + return kvm_x86_ops->tlb_remote_flush_with_range; > > +} > > Seems that kvm_available_flush_tlb_with_range() is not used in this patch… What's wrong with that? It provides the implementation and later patches make use of it. It's a sensible way to split patches into small, self contained entities. Thanks, tglx --8323329-68457485-1539505017=:1438--