From: Matthew DeVore <matvore@comcast.net>
To: Jeff King <peff@peff.net>
Cc: Andreas Gruenbacher <agruenba@redhat.com>,
git@vger.kernel.org, rpeterso@redhat.com,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [RFC] revision: Add --sticky-default option
Date: Wed, 17 Oct 2018 06:24:05 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.21.1810170620260.166761@matvore-linux.svl.corp.google.com> (raw)
In-Reply-To: <20181017091215.GA2052@sigill.intra.peff.net>
On Wed, 17 Oct 2018, Jeff King wrote:
>
> Yuck, t4202 is a mix of older and newer styles. I'm OK with this as-is
> because you've matched the surrounding code, but these days I'd probably
> write:
>
> test_expect_success '--sticky-default ^<rev>' '
> {
> echo sixth
> echo fifth
> } >expect &&
> git log --format=%s --sticky-default ^HEAD~2 >actual &&
> test_cmp expect actual
> '
>
How about test_write_lines? That is a little more readable to me than
the echos in a subshell. A patch was recently queued with a usage of
that function:
https://public-inbox.org/git/CAMfpvhK4a15gd-PT3W+4YJmpe6c7HyhJE5N_UqOzu8gsYYej4A@mail.gmail.com/T/#m9b5ade1551722938ac97b75af58fec195f246c01
- Matt
next prev parent reply other threads:[~2018-10-17 13:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-16 21:24 [RFC] revision: Add --sticky-default option Andreas Gruenbacher
2018-10-17 9:12 ` Jeff King
2018-10-17 13:24 ` Matthew DeVore [this message]
2018-10-17 18:11 ` Jeff King
2018-10-17 13:53 ` Andreas Gruenbacher
2018-10-17 18:13 ` Jeff King
2018-10-18 3:23 ` Junio C Hamano
2018-10-18 6:48 ` Jeff King
2018-10-18 6:59 ` Junio C Hamano
2018-10-18 12:17 ` Andreas Gruenbacher
2018-10-18 12:26 ` Junio C Hamano
2018-10-18 12:23 ` Andreas Gruenbacher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1810170620260.166761@matvore-linux.svl.corp.google.com \
--to=matvore@comcast.net \
--cc=agruenba@redhat.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=rpeterso@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.