From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julia Lawall Subject: Re: [Outreachy kernel] [PATCH DRM] drm: msm: adreno: Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) +PTR_ERR Date: Fri, 19 Oct 2018 08:18:52 +0200 (CEST) Message-ID: References: <20181018204815.GA23390@armorer> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail3-relais-sop.national.inria.fr (mail3-relais-sop.national.inria.fr [192.134.164.104]) by gabe.freedesktop.org (Postfix) with ESMTPS id F22776E1CD for ; Fri, 19 Oct 2018 06:18:56 +0000 (UTC) In-Reply-To: <20181018204815.GA23390@armorer> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Mamta Shukla Cc: airlied@linux.ie, outreachy-kernel@googlegroups.com, dri-devel@lists.freedesktop.org, daniel.vetter@ffwll.ch List-Id: dri-devel@lists.freedesktop.org CgpPbiBGcmksIDE5IE9jdCAyMDE4LCBNYW10YSBTaHVrbGEgd3JvdGU6Cgo+IFVzZSBQVFJfRVJS X09SX1pFUk8gcmF0aGVyIHRoYW4gaWYoSVNfRVJSKC4uLikpICsgUFRSX0VSUiBiZWNhdXNlIGl0 cwo+IGJldHRlciB0byBoYXZlIGlubGluZWQgZnVuY3Rpb24gcmF0aGVyIHRoYW4gY29kZS1vcGVu ZWQgaW1wbGVtZW50YXRpb24uCgoKSnVzdCBmb3IgeW91ciBpbmZvcm1hdGlvbiwgcGVvcGxlIGhh dmUgbWl4ZWQgZmVlbGluZ3MgYWJvdXQgdGhpcy4gIEluIHlvdXIKY2FzZSwgaXQncyBwcm9iYWJs eSBmaW5lLCBiZWNhdXNlIHRoaXMgaXMgdGhlIG9ubHkgaWYgaW4gdGhlIGZ1bmN0aW9uLgpCdXQg d2hlbiB0aGVyZSBpcyBhIHNlcmllcyBvZiBpZiAoLi4uKSByZXR1cm47IGZvbGxvd2VkIGJ5IGEg cmV0dXJuIDA7IGF0CnRoZSBlbmQsIHBlb3BsZSBvZmVuIHByZWZlciB0byBrZWVwIGl0IGFzIGl0 IGlzLCBzbyB0aGUgbGFzdCBjYXNlIGRvZXNuJ3QKbG9vayBkaWZmZXJlbnQgdGhhbiB0aGUgb3Ro ZXJzLgoKanVsaWEKCj4KPiBTaWduZWQtb2ZmLWJ5OiBNYW10YSBTaHVrbGEgPG1hbXRhc2h1a2xh NTU1QGdtYWlsLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL21zbS9hZHJlbm8vYTV4eF9n cHUuYyB8IDUgKy0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCA0IGRlbGV0 aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9tc20vYWRyZW5vL2E1eHhf Z3B1LmMgYi9kcml2ZXJzL2dwdS9kcm0vbXNtL2FkcmVuby9hNXh4X2dwdS5jCj4gaW5kZXggNmE2 ODQ5My4uYjc1MWI3NiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vbXNtL2FkcmVuby9h NXh4X2dwdS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL21zbS9hZHJlbm8vYTV4eF9ncHUuYwo+ IEBAIC0xMjIyLDEwICsxMjIyLDcgQEAgc3RhdGljIGludCBhNXh4X2NyYXNoZHVtcGVyX2luaXQo c3RydWN0IG1zbV9ncHUgKmdwdSwKPiAgCQlTWl8xTSwgTVNNX0JPX1VOQ0FDSEVELCBncHUtPmFz cGFjZSwKPiAgCQkmZHVtcGVyLT5ibywgJmR1bXBlci0+aW92YSk7Cj4KPiAtCWlmIChJU19FUlIo ZHVtcGVyLT5wdHIpKQo+IC0JCXJldHVybiBQVFJfRVJSKGR1bXBlci0+cHRyKTsKPiAtCj4gLQly ZXR1cm4gMDsKPiArCXJldHVybiBQVFJfRVJSX09SX1pFUk8oZHVtcGVyLT5wdHIpOwo+ICB9Cj4K PiAgc3RhdGljIHZvaWQgYTV4eF9jcmFzaGR1bXBlcl9mcmVlKHN0cnVjdCBtc21fZ3B1ICpncHUs Cj4gLS0KPiAxLjkuMQo+Cj4gLS0KPiBZb3UgcmVjZWl2ZWQgdGhpcyBtZXNzYWdlIGJlY2F1c2Ug eW91IGFyZSBzdWJzY3JpYmVkIHRvIHRoZSBHb29nbGUgR3JvdXBzICJvdXRyZWFjaHkta2VybmVs IiBncm91cC4KPiBUbyB1bnN1YnNjcmliZSBmcm9tIHRoaXMgZ3JvdXAgYW5kIHN0b3AgcmVjZWl2 aW5nIGVtYWlscyBmcm9tIGl0LCBzZW5kIGFuIGVtYWlsIHRvIG91dHJlYWNoeS1rZXJuZWwrdW5z dWJzY3JpYmVAZ29vZ2xlZ3JvdXBzLmNvbS4KPiBUbyBwb3N0IHRvIHRoaXMgZ3JvdXAsIHNlbmQg ZW1haWwgdG8gb3V0cmVhY2h5LWtlcm5lbEBnb29nbGVncm91cHMuY29tLgo+IFRvIHZpZXcgdGhp cyBkaXNjdXNzaW9uIG9uIHRoZSB3ZWIgdmlzaXQgaHR0cHM6Ly9ncm91cHMuZ29vZ2xlLmNvbS9k L21zZ2lkL291dHJlYWNoeS1rZXJuZWwvMjAxODEwMTgyMDQ4MTUuR0EyMzM5MCU0MGFybW9yZXIu Cj4gRm9yIG1vcmUgb3B0aW9ucywgdmlzaXQgaHR0cHM6Ly9ncm91cHMuZ29vZ2xlLmNvbS9kL29w dG91dC4KPgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpk cmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6613801848773017600 X-Received: by 2002:a1c:8a46:: with SMTP id m67-v6mr186436wmd.0.1539929934613; Thu, 18 Oct 2018 23:18:54 -0700 (PDT) X-BeenThere: outreachy-kernel@googlegroups.com Received: by 2002:a1c:3442:: with SMTP id b63-v6ls266390wma.12.canary-gmail; Thu, 18 Oct 2018 23:18:53 -0700 (PDT) X-Google-Smtp-Source: ACcGV61gDShBSu7sfJDHYDNYO+85CD/A8Tcu7KS0BNsSx8C8WAsHktT6b/isWvHMn4xPhtcBqCzg X-Received: by 2002:a1c:9906:: with SMTP id b6-v6mr197723wme.1.1539929933186; Thu, 18 Oct 2018 23:18:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539929933; cv=none; d=google.com; s=arc-20160816; b=ruAMkMUmoiosy20hgiv9y20rEvm5ni7UrKwssvu4qf76oU69j+ZTQ3vhTj8nV0xxzI yxdAvn/Ee90U+HsObLW4N2oKTkKehpeyN62VqYNNJM9yG3WEI2Ai8vobnYfa+Az1wso5 NubdJi0czQHNfudZiWGMGtP9hIFF6Y4LNSHGyeMe9BsYDgOLtbaBx64B9onA5VJhiwyC z+30pmyhOHqCpUCvxLXRa9qj3sulqEF3qD6K2S6Q3ffnEgDx8XTb8d3R0Q3hcUPn7zq6 xSsRqJDTZpGkaxYT1iExvse4oV6c7oJcccXqESmOrv0MH/MRGzuaxIigtxNvSyKpORrb EBEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:user-agent:references:message-id:in-reply-to:subject :cc:to:from:date; bh=1BXUmVSm6WkNWdDr+VKROTz+GuY7nHnCAMfU6m0RSSE=; b=NFJ7nDsRQc8cUJaGmKobVhZJFl9GHN/qLcMsHlfblYM/zzXFH2Y3hjJuh4cI8E7bla Jips09nVjrOVn7NkaXCzxodpQK5207Cn+AwlSqYUiDIbZzRHzk/mWqgxoAhJBfK7hVjR DdNjdO2j+wUyNLXG1a98aprBts/bDJOjSfvyyasukjWW7VOzBMS0VRD8RXBsiscmih4u Dd6T58XaMEY1T2j6VXyTIDdNjuayV0GzTcNEj6hu03Ng6xTiCUlhx2F5LfgBoF8aZjGD 4XcZtpKwGkT42vrxSvilECES6L0Fn4uKelersfvGMHwOmjItBiF+r5p+ReiBLpzhI43h ySkw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=neutral (google.com: 192.134.164.104 is neither permitted nor denied by domain of julia.lawall@lip6.fr) smtp.mailfrom=julia.lawall@lip6.fr Return-Path: Received: from mail3-relais-sop.national.inria.fr (mail3-relais-sop.national.inria.fr. [192.134.164.104]) by gmr-mx.google.com with ESMTPS id z62-v6si153892wmc.2.2018.10.18.23.18.53 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 18 Oct 2018 23:18:53 -0700 (PDT) Received-SPF: neutral (google.com: 192.134.164.104 is neither permitted nor denied by domain of julia.lawall@lip6.fr) client-ip=192.134.164.104; Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 192.134.164.104 is neither permitted nor denied by domain of julia.lawall@lip6.fr) smtp.mailfrom=julia.lawall@lip6.fr X-IronPort-AV: E=Sophos;i="5.54,399,1534802400"; d="scan'208";a="282626892" Received: from 89-157-201-244.rev.numericable.fr (HELO hadrien) ([89.157.201.244]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Oct 2018 08:18:52 +0200 Date: Fri, 19 Oct 2018 08:18:52 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Mamta Shukla cc: outreachy-kernel@googlegroups.com, dri-devel@lists.freedesktop.org, daniel.vetter@ffwll.ch, robdclark@gmail.com, airlied@linux.ie Subject: Re: [Outreachy kernel] [PATCH DRM] drm: msm: adreno: Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) +PTR_ERR In-Reply-To: <20181018204815.GA23390@armorer> Message-ID: References: <20181018204815.GA23390@armorer> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Fri, 19 Oct 2018, Mamta Shukla wrote: > Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR because its > better to have inlined function rather than code-opened implementation. Just for your information, people have mixed feelings about this. In your case, it's probably fine, because this is the only if in the function. But when there is a series of if (...) return; followed by a return 0; at the end, people ofen prefer to keep it as it is, so the last case doesn't look different than the others. julia > > Signed-off-by: Mamta Shukla > --- > drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/msm/adreno/a5xx_gpu.c b/drivers/gpu/drm/msm/adreno/a5xx_gpu.c > index 6a68493..b751b76 100644 > --- a/drivers/gpu/drm/msm/adreno/a5xx_gpu.c > +++ b/drivers/gpu/drm/msm/adreno/a5xx_gpu.c > @@ -1222,10 +1222,7 @@ static int a5xx_crashdumper_init(struct msm_gpu *gpu, > SZ_1M, MSM_BO_UNCACHED, gpu->aspace, > &dumper->bo, &dumper->iova); > > - if (IS_ERR(dumper->ptr)) > - return PTR_ERR(dumper->ptr); > - > - return 0; > + return PTR_ERR_OR_ZERO(dumper->ptr); > } > > static void a5xx_crashdumper_free(struct msm_gpu *gpu, > -- > 1.9.1 > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To post to this group, send email to outreachy-kernel@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20181018204815.GA23390%40armorer. > For more options, visit https://groups.google.com/d/optout. >