All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Lukas Wunner <lukas@wunner.de>
Cc: linux-kernel@vger.kernel.org,
	Mathias Duckeck <m.duckeck@kunbus.de>,
	Akshay Bhat <akshay.bhat@timesys.com>,
	Casey Fitzpatrick <casey.fitzpatrick@timesys.com>
Subject: Re: [PATCH] genirq: Fix race on spurious interrupt detection
Date: Fri, 19 Oct 2018 17:26:29 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.21.1810191725220.6075@nanos.tec.linutronix.de> (raw)
In-Reply-To: <20181019152307.62t6al6ney5ofo36@wunner.de>

On Fri, 19 Oct 2018, Lukas Wunner wrote:
> On Fri, Oct 19, 2018 at 04:31:30PM +0200, Thomas Gleixner wrote:
> > I doubt that this can happen in reality, so I'd rather reword that
> > paragraph slightly:
> > 
> >   In theory high CPU load and in the presence of higher priority tasks, the
> >   number of incorrectly detected spurious interrupts might increase beyond
> >   the 99,900 threshold and cause disablement of the interrupt.
> > 
> >   In practice it just increments the spurious interrupt count. But that can
> >   cause people to waste time investigating it over and over.
> > 
> > Hmm?
> 
> Sure, fine by me.  Would you prefer me to resend with that change or
> can you fold it in when applying?

I'll fold it. No problem.

> FWIW I did manage to reach the 99,900 threshold once because I had
> added copious amounts of printk() to the hi3110 IRQ thread to debug
> another issue.  But I never experienced that without those printk()'s.

Cute.

Thanks

	tglx

  reply	other threads:[~2018-10-19 15:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-18 13:15 [PATCH] genirq: Fix race on spurious interrupt detection Lukas Wunner
2018-10-19 14:31 ` Thomas Gleixner
2018-10-19 15:23   ` Lukas Wunner
2018-10-19 15:26     ` Thomas Gleixner [this message]
2018-10-19 15:33 ` [tip:irq/core] " tip-bot for Lukas Wunner
2018-10-19 16:14   ` David Laight
2018-10-19 18:41     ` Thomas Gleixner
2018-10-19 20:26       ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.21.1810191725220.6075@nanos.tec.linutronix.de \
    --to=tglx@linutronix.de \
    --cc=akshay.bhat@timesys.com \
    --cc=casey.fitzpatrick@timesys.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lukas@wunner.de \
    --cc=m.duckeck@kunbus.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.