From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6783BC43387 for ; Wed, 16 Jan 2019 22:02:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 38DEB206C2 for ; Wed, 16 Jan 2019 22:02:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732245AbfAPWB7 (ORCPT ); Wed, 16 Jan 2019 17:01:59 -0500 Received: from Galois.linutronix.de ([146.0.238.70]:45918 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732123AbfAPWB7 (ORCPT ); Wed, 16 Jan 2019 17:01:59 -0500 Received: from p4fea4364.dip0.t-ipconnect.de ([79.234.67.100] helo=nanos) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1gjtFx-0000fI-Ne; Wed, 16 Jan 2019 23:01:53 +0100 Date: Wed, 16 Jan 2019 23:01:53 +0100 (CET) From: Thomas Gleixner To: Yangtao Li cc: douliyangs@gmail.com, marc.zyngier@arm.com, rdunlap@infradead.org, palmer@sifive.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] irq: convert the code format to BIT() In-Reply-To: <20190116160305.20639-1-tiny.windzz@gmail.com> Message-ID: References: <20190116160305.20639-1-tiny.windzz@gmail.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 16 Jan 2019, Yangtao Li wrote: > Use BIT() to do some clean-up. I don't see what the clean-up is. The existing one is perfectly clean code. Thanks, tglx