From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96A8AC43444 for ; Fri, 18 Jan 2019 10:22:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 64C6F20823 for ; Fri, 18 Jan 2019 10:22:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727020AbfARKWs (ORCPT ); Fri, 18 Jan 2019 05:22:48 -0500 Received: from Galois.linutronix.de ([146.0.238.70]:48982 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726864AbfARKWs (ORCPT ); Fri, 18 Jan 2019 05:22:48 -0500 Received: from p4fea4364.dip0.t-ipconnect.de ([79.234.67.100] helo=nanos) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1gkRIP-0003vY-3J; Fri, 18 Jan 2019 11:22:41 +0100 Date: Fri, 18 Jan 2019 11:22:39 +0100 (CET) From: Thomas Gleixner To: Michael Schmitz cc: netdev@vger.kernel.org, andrew@lunn.ch, fthain@telegraphics.com.au, geert@linux-m68k.org, f.fainelli@gmail.com, linux-m68k@vger.kernel.org, Michael.Karcher@fu-berlin.de, LKML , Greg KH , Kate Stewart Subject: Re: [v4,1/9] net-next: phy: new Asix Electronics PHY driver In-Reply-To: <1524103526-12240-2-git-send-email-schmitzmic@gmail.com> Message-ID: References: <1524103526-12240-2-git-send-email-schmitzmic@gmail.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Michael, On Thu, 19 Apr 2018, Michael Schmitz wrote: > --- /dev/null > +++ b/drivers/net/phy/asix.c > @@ -0,0 +1,63 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* Driver for Asix PHYs > + * > + * Author: Michael Schmitz > + * > + * This program is free software; you can redistribute it and/or modify it > + * under the terms of the GNU General Public License as published by the > + * Free Software Foundation; either version 2 of the License, or (at your > + * option) any later version. > + * > + */ This license information is broken. The SPDX license identifier and the boiler plate text are contradicting. The SPDX id is GPL v2 only and the boiler plate says v2 or later. Please decide which version you want and fix ASAP. If you fix that up please add a Fixes: tag and cc stable. While at it please remove the boiler plate text as the SPDX id is sufficient and the boiler plate is redundant information. See Documentation/process/license-rules.txt Thanks, tglx