From: Thomas Gleixner <tglx@linutronix.de>
To: Waiman Long <longman@redhat.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Matthew Wilcox <willy@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>,
Alexey Dobriyan <adobriyan@gmail.com>,
Kees Cook <keescook@chromium.org>,
linux-fsdevel@vger.kernel.org,
Davidlohr Bueso <dave@stgolabs.net>,
Miklos Szeredi <miklos@szeredi.hu>,
Daniel Colascione <dancol@google.com>,
Dave Chinner <david@fromorbit.com>,
Randy Dunlap <rdunlap@infradead.org>,
Marc Zyngier <marc.zyngier@arm.com>
Subject: Re: [patch 1/2] genriq: Avoid summation loops for /proc/stat
Date: Wed, 30 Jan 2019 18:58:32 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.21.1901301857350.1622@nanos.tec.linutronix.de> (raw)
In-Reply-To: <00f361f9-b1ec-777b-b794-d7728a357034@redhat.com>
On Wed, 30 Jan 2019, Waiman Long wrote:
> On 01/30/2019 07:31 AM, Thomas Gleixner wrote:
> > --- a/include/linux/irqdesc.h
> > +++ b/include/linux/irqdesc.h
> > @@ -65,9 +65,10 @@ struct irq_desc {
> > unsigned int core_internal_state__do_not_mess_with_it;
> > unsigned int depth; /* nested irq disables */
> > unsigned int wake_depth; /* nested wake enables */
> > + unsigned int tot_count;
> > unsigned int irq_count; /* For detecting broken IRQs */
> > - unsigned long last_unhandled; /* Aging timer for unhandled count */
> > unsigned int irqs_unhandled;
> > + unsigned long last_unhandled; /* Aging timer for unhandled count */
> > atomic_t threads_handled;
> > int threads_handled_last;
> > raw_spinlock_t lock;
>
> Just one minor nit. Why you want to move the last_unhandled down one
> slot? There were 5 int's before. Adding one more will just fill the
> padding hole. Moving down the last_unhandled will probably leave 4-byte
> holes in both above and below it assuming that raw_spinlock_t is 4 bytes.
Unintentional wreckage. Will undo. Thanks for spotting it.
Thanks,
tglx
next prev parent reply other threads:[~2019-01-30 17:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-30 12:31 [patch 0/2] genirq, proc: Speedup /proc/stat interrupt statistics Thomas Gleixner
2019-01-30 12:31 ` [patch 1/2] genriq: Avoid summation loops for /proc/stat Thomas Gleixner
2019-01-30 16:00 ` Waiman Long
2019-01-30 17:58 ` Thomas Gleixner [this message]
2019-01-30 12:31 ` [patch 2/2] proc/stat: Make the interrupt statistics more efficient Thomas Gleixner
2019-01-30 21:24 ` Alexey Dobriyan
2019-01-30 21:27 ` Thomas Gleixner
2019-01-30 15:46 ` [patch 0/2] genirq, proc: Speedup /proc/stat interrupt statistics Waiman Long
2019-01-30 21:58 ` Andrew Morton
2019-01-30 22:00 ` Thomas Gleixner
2019-01-30 22:09 ` Waiman Long
2019-01-31 3:46 ` Waiman Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1901301857350.1622@nanos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=dancol@google.com \
--cc=dave@stgolabs.net \
--cc=david@fromorbit.com \
--cc=keescook@chromium.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=marc.zyngier@arm.com \
--cc=miklos@szeredi.hu \
--cc=rdunlap@infradead.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.