From: Thomas Gleixner <tglx@linutronix.de>
To: Dongli Zhang <dongli.zhang@oracle.com>
Cc: xen-devel@lists.xenproject.org, stable@vger.kernel.org,
linux-kernel@vger.kernel.org, boris.ostrovsky@oracle.com,
sstabellini@kernel.org, jgross@suse.com, joe.jin@oracle.com,
Herbert Van Den Bergh <herbert.van.den.bergh@oracle.com>,
sboyd@kernel.org, john.stultz@linaro.org
Subject: Re: [BUG linux-4.9.x] xen hotplug cpu leads to 100% steal usage
Date: Sat, 2 Mar 2019 00:43:47 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.21.1903020030320.1638@nanos.tec.linutronix.de> (raw)
In-Reply-To: <841bb9a9-1cba-483f-a353-1209684f7c74@default>
On Thu, 28 Feb 2019, Dongli Zhang wrote:
>
> The root cause is that the return type of jiffies_to_usecs() is 'unsigned int',
> but not 'unsigned long'. As a result, the leading 32 bits are discarded.
Errm. No. The root cause is that jiffies_to_usecs() is used for that in the
first place. The function has been that way forever and all usage sites
(except a broken dev_debug print in infiniband) feed delta values. Yes, it
could have documentation....
> jiffies_to_usecs() is indirectly triggered by cputime_to_nsecs() at line 264.
> If guest is already up for long time, the initial steal time for new vcpu might
> be large and the leading 32 bits of jiffies_to_usecs() would be discarded.
> So far, I have two solutions:
>
> 1. Change the return type from 'unsigned int' to 'unsigned long' as in above
> link and I am afraid it would bring side effect. The return type in latest
> mainline kernel is still 'unsigned int'.
Changing it to unsigned long would just solve the issue for 64bit.
Thanks,
tglx
next prev parent reply other threads:[~2019-03-01 23:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-01 2:35 [BUG linux-4.9.x] xen hotplug cpu leads to 100% steal usage Dongli Zhang
2019-03-01 23:43 ` Thomas Gleixner
2019-03-01 23:43 ` Thomas Gleixner [this message]
2019-03-05 2:19 ` Dongli Zhang
2019-03-05 2:19 ` Dongli Zhang
2019-03-04 8:14 ` Juergen Gross
2019-03-05 2:14 ` Dongli Zhang
2019-03-05 2:14 ` Dongli Zhang
2019-03-04 8:14 ` Juergen Gross
-- strict thread matches above, loose matches on Subject: below --
2019-03-01 2:35 Dongli Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1903020030320.1638@nanos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=boris.ostrovsky@oracle.com \
--cc=dongli.zhang@oracle.com \
--cc=herbert.van.den.bergh@oracle.com \
--cc=jgross@suse.com \
--cc=joe.jin@oracle.com \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sboyd@kernel.org \
--cc=sstabellini@kernel.org \
--cc=stable@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.