From: Julia Lawall <julia.lawall@lip6.fr>
To: Wentao Cai <etsai042@gmail.com>
Cc: gregkh@linuxfoundation.org, outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH 1/4] Staging: most: dim2: Fix malformed SPDX-License-Identifier
Date: Wed, 6 Mar 2019 08:08:59 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.21.1903060807170.2706@hadrien> (raw)
In-Reply-To: <20190306043941.6141-1-etsai042@gmail.com>
On Tue, 5 Mar 2019, Wentao Cai wrote:
> This patch fixes the checkpatch.pl warning:
> WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
Hello,
When you make a series, you should also make a cover letter that gives an
overview of what is done in the series. You can find information about
how to do this in the tutorial.
Also, previously Greg has asked that patches that add SPDX identifiers be
accompanised by subsequent patches that remove existing boilerplate
license text, if there is any. So you may want to check on this.
julia
>
> Signed-off-by: Wentao Cai <etsai042@gmail.com>
> ---
> drivers/staging/most/dim2/errors.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/most/dim2/errors.h b/drivers/staging/most/dim2/errors.h
> index 3487510fbd2f..cbbdaaf5c52d 100644
> --- a/drivers/staging/most/dim2/errors.h
> +++ b/drivers/staging/most/dim2/errors.h
> @@ -1,4 +1,4 @@
> -// SPDX-License-Identifier: GPL-2.0
> +/* SPDX-License-Identifier: GPL-2.0+ */
> /*
> * errors.h - Definitions of errors for DIM2 HAL API
> * (MediaLB, Device Interface Macro IP, OS62420)
> --
> 2.11.0
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190306043941.6141-1-etsai042%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
next prev parent reply other threads:[~2019-03-06 7:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-06 4:39 [PATCH 1/4] Staging: most: dim2: Fix malformed SPDX-License-Identifier Wentao Cai
2019-03-06 4:39 ` [PATCH 2/4] " Wentao Cai
2019-03-06 4:39 ` [PATCH 3/4] " Wentao Cai
2019-03-06 4:39 ` [PATCH 4/4] " Wentao Cai
2019-03-06 7:08 ` Julia Lawall [this message]
2019-03-06 9:07 ` [Outreachy kernel] [PATCH 1/4] " Greg KH
2019-03-07 10:35 ` etsai042
2019-03-06 9:08 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1903060807170.2706@hadrien \
--to=julia.lawall@lip6.fr \
--cc=etsai042@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.